langgraph-js-elasticsearch supporting blog content #511
Conversation
|
Review these changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/511 |
|
Hi! @carlyrichmond I moved this pull request (#494) here. For some reason, the pre-commit checks didn’t pass in that PR, but it seems the issue doesn’t appear here. |
|
@Delacrobix I don't quite understand why you've closed the other PR as both look to be needed if you have an accompanying notebook. This one is the for the blog content and 494 is for the accompanying notebook in the public repo. I had flagged to @Celine-Elastic yesterday that there was still outstanding comments on the notebook PR that didn't look like they had been addressed. Can you check and confirm so we can get the notebook merged? I've reopened it as you closed it without merging changes, which I'm not sure you intended to do. |
|
Hi again! @carlyrichmond This blog post does not include any notebook because it uses JavaScript as programming language. I double-checked in case I had accidentally added one, but there isn’t any. Both pull requests (#494) and this one contain the same files. I’m trying to find the comments you mentioned, but I haven’t been able to locate them. Could you please link them? Or maybe there was a confusion with another blog post? Please let me know. I’ll attach a screenshot showing all the comments I have in pull request #494 as well |
|
Apologies, it's JS code rather than a notebook. But there are still comments marked as pending that potentially need to be resolved: 
@Delacrobix can you take a look please? |
That’s odd. I’m sorry, but as I mentioned, I am not able to see those comments. Anyway, I resolved the ones you showed in the screenshot. In pull request #494 there is a new commit with those changes. If there are more unresolved comments, could you please share them with me? I’d be thankful. |
2 participants
No description provided.