Skip to content

deprecate percolate and correct/remove dead percolator links #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

deprecate percolate and correct/remove dead percolator links #713

wants to merge 1 commit into from

Conversation

roelandvanbatenburg
Copy link
Contributor

Closes #469

  • added depreciation to percolator functions in 5.x
  • corrected percolator links in 5.x
  • removed percolator links in 6.x

@spalger
Copy link
Contributor

spalger commented Oct 23, 2018

Thanks for the contribution @roelandvanbatenburg, but the APIs are actually generated from the rest-api-spec defined in the Elasticsearch repository, so any changes should be done there. Would you mind resubmitting your changes in two PRs, one to the 5.6 version of the spec and one to the 6.x version of the spec?

@roelandvanbatenburg
Copy link
Contributor Author

@spalger sure like this ⬆️ ?

@roelandvanbatenburg roelandvanbatenburg deleted the feature/deprecate_percolate branch October 23, 2018 19:13
@roelandvanbatenburg
Copy link
Contributor Author

@spalger I can't find where the text for https://github.com/elastic/elasticsearch-js/pull/713/files#diff-c8cefc06ace53a4a974417e0d69af6d4L624 is defined. Are you sure these files origin from the elasticsearch repo?

@spalger
Copy link
Contributor

spalger commented Oct 24, 2018

Ah, those descriptions are actually defined in https://github.com/elastic/elasticsearch-js/blob/277d33715c45d7f8f2c0ad09f08136cf6ef12cea/docs/_descriptions/explain.asciidoc (forgot we have a couple extra bits in here, as well as some overrides). If you delete that file and then regenerate the api with node scripts/generate that text will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants