Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not map ClassVar attributes #1936

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Do not map ClassVar attributes #1936

merged 3 commits into from
Nov 6, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

Fixes #1927

pquentin
pquentin approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Nov 6, 2024
@miguelgrinberg miguelgrinberg merged commit 47a7a06 into elastic:main Nov 6, 2024
19 checks passed
@miguelgrinberg miguelgrinberg deleted the ignore-classvar-attrs branch November 6, 2024 18:29
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
@miguelgrinberg @github-actions
Do not map ClassVar attributes (#1936)
913e8aa 
* Do not map ClassVar attributes

Fixes #1927

* document ClassVar usage

(cherry picked from commit 47a7a06)
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Merged
miguelgrinberg added a commit that referenced this pull request Nov 6, 2024
@github-actions @miguelgrinberg
Do not map ClassVar attributes (#1936) (#1941)
51558ad 
* Do not map ClassVar attributes

Fixes #1927

* document ClassVar usage

(cherry picked from commit 47a7a06)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.x Backport to 8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify ignored attributes in mappings
2 participants
@miguelgrinberg @pquentin