Skip to content

[docs] Fix image paths for docs-assembler #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Apr 16, 2025

Related: elastic/docs-builder#1140

Fixes image paths to work with docs-assembler.

Notes for the reviewer:

  • I was not able to get images in reference, extend, or release-notes to work using the :::{image} syntax because it seems to resolve differently than the Markdown ![]() syntax. We should address this in docs-builder, but in order to get images working as soon as possible, I've used Markdown syntax and left us a TO DO in a code comment to add back the screenshot class where applicable.
  • Can you please add the appropriate labels needed for backporting?

@colleenmcginnis colleenmcginnis added documentation Improvements or additions to documentation Team:Docs Label for the Observability docs team docs labels Apr 16, 2025
@colleenmcginnis colleenmcginnis self-assigned this Apr 16, 2025
Copy link

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against f87132b

@colleenmcginnis colleenmcginnis marked this pull request as ready for review April 16, 2025 17:54
@colleenmcginnis colleenmcginnis requested review from alaudazzi and a team April 16, 2025 17:55
@colleenmcginnis colleenmcginnis enabled auto-merge (squash) April 16, 2025 18:02
Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦕

@colleenmcginnis colleenmcginnis merged commit 4425bca into elastic:main Apr 16, 2025
6 checks passed
@colleenmcginnis colleenmcginnis deleted the fix-images-when-assembled branch April 16, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation Improvements or additions to documentation Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants