Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report benchmark command can compare against a specific version #1040

Open
marc-gr opened this issue Nov 14, 2022 · 0 comments
Open

Report benchmark command can compare against a specific version #1040

marc-gr opened this issue Nov 14, 2022 · 0 comments
Assignees
@marc-gr
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@marc-gr
Copy link
Contributor

marc-gr commented Nov 14, 2022 •
edited
Loading

Benchmarking against previous package version should be allowed ideally by downloading/checking out the specific version and comparing both runs. This requires elastic/package-spec#446 so we can checkout the commit since packages in the registry do not have the required testing assets.
@marc-gr marc-gr mentioned this issue Nov 14, 2022
Closed
3 tasks
@jlind23 jlind23 added the Team:Ecosystem Label for the Packages Ecosystem team label Nov 14, 2022
@marc-gr marc-gr changed the title Benchmarking against previous package version. Need to figure out what's the best way to implement this, possibly just comparing the output of two benchmark runs, similar to Go's benchcmp / benchstat. Report benchmark command can compare against a specific version Nov 14, 2022
@marc-gr marc-gr self-assigned this Nov 14, 2022
@marc-gr marc-gr mentioned this issue Nov 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc-gr marc-gr

Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marc-gr @jlind23