refactor: enable noUncheckedIndexedAccess (#2006)

enables stricter types for array access.

BREAKING CHANGE: Enables stricter type option in src and could have
unexpected changes. This release is meant to serve as a clean break
in case any issues arise.

Author: nickofthyme

.buildkite/utils/github.ts

@@ -229,8 +229,8 @@ export const updateCheckStatus = async (
   // revert the completed check run is to create a new check run. This will not show as a duplicate run.
   const newCheckNeeded = options.status !== 'completed' && checkRun?.status === 'completed';
 
-  console.trace('updateCheckStatus', checkId, title);
-  console.log(JSON.stringify(options, null, 2));
+  // console.trace('updateCheckStatus', checkId, title);
+  // console.log(JSON.stringify(options, null, 2));
 
   try {
     const output =

e2e/page_objects/common.ts

@@ -167,7 +167,7 @@ export class CommonPage {
 
   static validatePath(path: string | string[]): string | string[] {
     const fileName = Array.isArray(path) ? path[path.length - 1] : path;
-    if (/\.png$/.test(fileName)) return path;
+    if (fileName && /\.png$/.test(fileName)) return path;
     throw new Error(`Screenshot path or last path segment must contain the .png file extension.`);
   }
 

e2e/tests/legend_stories.test.ts

@@ -208,7 +208,7 @@ test.describe('Legend stories', () => {
     const getPositionalUrl = (p1: string, p2: string, others: string = '') =>
       `http://localhost:9001/?path=/story/legend--inside-chart&knob-vAlign_Legend=${p1}&knob-hAlign_Legend=${p2}${others}`;
 
-    pwEach.test([
+    pwEach.test<[Position, Position]>([
       [Position.Top, Position.Left],
       [Position.Top, Position.Right],
       [Position.Bottom, Position.Left],
@@ -220,7 +220,7 @@ test.describe('Legend stories', () => {
       },
     );
 
-    pwEach.test([
+    pwEach.test<[Position, Position]>([
       [Position.Top, Position.Left],
       [Position.Top, Position.Right],
       [Position.Bottom, Position.Left],
@@ -235,7 +235,7 @@ test.describe('Legend stories', () => {
     const longLabel =
       'Non do aliqua veniam dolore ipsum eu aliquip. Culpa in duis amet non velit qui non ullamco sit adipisicing. Ut sunt Lorem mollit exercitation deserunt officia sunt ipsum eu amet.';
 
-    pwEach.test([
+    pwEach.test<[Position, Position]>([
       [Position.Top, Position.Left],
       [Position.Top, Position.Right],
       [Position.Bottom, Position.Left],

github_bot/Dockerfile

@@ -2,7 +2,7 @@ FROM node:16-alpine as builder
 WORKDIR /app
 COPY package.json yarn.lock ./
 RUN yarn install --frozen-lockfile
-COPY tsconfig.json ./
+COPY tsconfig.main.json ./tsconfig.json
 COPY src src
 RUN yarn build
 

github_bot/src/github/events/push/trigger_build.ts

@@ -16,10 +16,15 @@ import { checkCommitFn, isBaseRepo, testPatternString, updateAllChecks } from '.
  * build trigger for pushes to select base branches not pull requests
  */
 export function setupBuildTrigger(app: Probot) {
+  // @ts-ignore - probot issue https://github.com/probot/probot/issues/1680
   app.on('push', async (ctx) => {
     const [branch] = ctx.payload.ref.split('/').reverse();
 
-    if (!isBaseRepo(ctx.payload.repository) || !getConfig().github.env.branch.base.some(testPatternString(branch))) {
+    if (
+      !branch ||
+      !isBaseRepo(ctx.payload.repository) ||
+      !getConfig().github.env.branch.base.some(testPatternString(branch))
+    ) {
       return;
     }
 

github_bot/src/github/utils.ts

@@ -259,6 +259,8 @@ export async function syncChecks(ctx: ProbotEventContext<'pull_request'>) {
 
   const [previousCommitSha] = await getLatestCommits(ctx);
 
+  if (!previousCommitSha) throw new Error('Unable to load previous commit');
+
   const {
     data: { check_runs: checks },
   } = await ctx.octokit.checks.listForRef({
@@ -348,14 +350,15 @@ export async function updatePreviousDeployments(
   await Promise.all(
     deployments.map(async ({ id }) => {
       const {
-        data: [{ environment, state: currentState, ...status }],
+        data: [data],
       } = await ctx.octokit.repos.listDeploymentStatuses({
         ...ctx.repo(),
         deployment_id: id,
         per_page: 1,
       });
 
-      if (['in_progress', 'queued', 'pending'].includes(currentState)) {
+      if (data && ['in_progress', 'queued', 'pending'].includes(data.state)) {
+        const { environment, ...status } = data;
         await ctx.octokit.repos.createDeploymentStatus({
           ...ctx.repo(),
           ...status,

github_bot/tsconfig.json renamed to github_bot/tsconfig.main.json

@@ -52,8 +52,10 @@
     "test:e2e:generate:page": "./e2e_server/scripts/compile_vrt_page.sh",
     "test:e2e:server": "sh ./e2e_server/scripts/start.sh",
     "test:e2e:server:build": "cd e2e_server/server && webpack build",
+    "typecheck:base": "tsc -p ./tsconfig.base.json --noEmit",
     "typecheck:src": "lerna run --loglevel=silent --scope @elastic/charts typecheck --stream --no-prefix",
-    "typecheck:all": "tsc -p ./tsconfig.json --noEmit",
+    "typecheck:storybook": "lerna run --loglevel=silent --scope charts-storybook typecheck --stream --no-prefix",
+    "typecheck:all": "yarn typecheck:base && yarn typecheck:src && yarn typecheck:storybook",
     "ts:prune": "ts-prune"
   },
   "devDependencies": {

package.json

@@ -78,7 +78,7 @@
      * SUPPORTED TOKENS: <projectFolder>, <packageName>, <unscopedPackageName>
      * DEFAULT VALUE: "<projectFolder>/tsconfig.json"
      */
-    "tsconfigFilePath": "<projectFolder>/tsconfig.json",
+    "tsconfigFilePath": "<projectFolder>/tsconfig.src.json",
     /**
      * Provides a compiler configuration that will be used instead of reading the tsconfig.json file from disk.
      * The object must conform to the TypeScript tsconfig schema:

packages/charts/api-extractor.jsonc

@@ -2247,7 +2247,7 @@ export type Ratio = number;
 export type RawTextGetter = (node: ShapeTreeNode) => string;
 
 // @public (undocumented)
-export const RectAnnotation: FC<SFProps<RectAnnotationSpec, "chartType" | "specType", "style" | "zIndex" | "groupId" | "outside" | "annotationType", "fallbackPlacements" | "placement" | "offset" | "boundary" | "boundaryPadding" | "customTooltip" | "customTooltipDetails" | "hideTooltips" | "animations" | "renderTooltip" | "outsideDimension", "id" | "dataValues">>;
+export const RectAnnotation: FC<SFProps<RectAnnotationSpec, "chartType" | "specType", "style" | "zIndex" | "groupId" | "outside" | "annotationType", "fallbackPlacements" | "placement" | "offset" | "boundary" | "boundaryPadding" | "customTooltip" | "hideTooltips" | "customTooltipDetails" | "animations" | "renderTooltip" | "outsideDimension", "id" | "dataValues">>;
 
 // @public
 export interface RectAnnotationDatum {