Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(2489): removed path.install option from the paths command, removed any usage of this command #6461

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

kaanyalti
Copy link
Contributor

  • Breaking change

What does this PR do?

Removes --path.install flag declaration from the paths command and removes its use from container and enroll commands

Why is it important?

This command is currently ignored and deprecated

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

Any client using --path.install flag will fail

How to test this PR locally

  • Deploy ess
  • Prepare necessary packages for testing
    • tar.gz
    • docker
  • Try to install tar.gz with path.install and verify that the installation fails
  • Install tar.gz without the flag and validate that the installation is successful
  • Unenroll the agent on fleet ui, and then enroll the agent again and validate that enrollment is successful
  • Run agent in docker and validate that it is successfully run

Related issues

@kaanyalti kaanyalti requested a review from a team as a code owner December 31, 2024 18:29
Copy link
Contributor

mergify bot commented Dec 31, 2024

This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 31, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 31, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jlind23 jlind23 added backport-skip and removed backport-8.x Automated backport to the 8.x branch with mergify labels Jan 2, 2025
@jlind23
Copy link
Contributor

jlind23 commented Jan 2, 2025

Removing the backport label as this should remain on main.

@swiatekm swiatekm added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@kaanyalti kaanyalti merged commit 6c005a4 into elastic:main Jan 2, 2025
16 checks passed
@kaanyalti kaanyalti deleted the cleanup/2489_remove_path.install branch January 2, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove --path.install option
5 participants