[helm] fix disabling cluster role and service account #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
added
bug
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
swiatekm
approved these changes
Nov 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* fix: allow disabling cluster role creation without needing to specify an existing one * fix: fallback to default service account when creation is disabled and no existing one is specified * fix: update nginx custom integration to disable all k8s agent providers (cherry picked from commit a0111f1) # Conflicts: # deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml
7 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* fix: allow disabling cluster role creation without needing to specify an existing one * fix: fallback to default service account when creation is disabled and no existing one is specified * fix: update nginx custom integration to disable all k8s agent providers (cherry picked from commit a0111f1) # Conflicts: # deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml
7 tasks
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 13, 2024
…account (#6008) * [helm] fix disabling cluster role and service account (#6004) * fix: allow disabling cluster role creation without needing to specify an existing one * fix: fallback to default service account when creation is disabled and no existing one is specified * fix: update nginx custom integration to disable all k8s agent providers (cherry picked from commit a0111f1) # Conflicts: # deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml * fix: resolve conflicts --------- Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 13, 2024
…ccount (#6009) * [helm] fix disabling cluster role and service account (#6004) * fix: allow disabling cluster role creation without needing to specify an existing one * fix: fallback to default service account when creation is disabled and no existing one is specified * fix: update nginx custom integration to disable all k8s agent providers (cherry picked from commit a0111f1) # Conflicts: # deploy/helm/elastic-agent/examples/nginx-custom-integration/rendered/manifest.yaml * fix: resolve conflicts --------- Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves two key issues:
defaultservice account by disabling service account creation without specifying an existing one.Additionally, it updates the nginx custom integration example to demonstrate how to deploy an elastic agent with Kubernetes providers, leader election, cluster role, and service account creation all disabled.
Why is it important?
These changes are essential for improving the configuration flexibility of the deployment process. By allowing cluster role creation to be disabled without requiring the specification of an existing role name, users gain the ability to simplify permissions management. This is particularly useful in environments where pre-configured roles or restricted permissions are mandated.
Furthermore, the option to fall back to the default service account without creating a new one or specifying an existing account name enhances compatibility with Kubernetes setups that have stringent service account policies or rely on default configurations. This ensures smoother integration and reduces the complexity for users deploying the elastic agent in a wide variety of Kubernetes environments.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A
How to test this PR locally
Follow the updated nginx custom integration example
Related issues
N/A