Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ironbank: move to ubi9 #3691

Merged
merged 1 commit into from
Nov 6, 2023
Merged

ironbank: move to ubi9 #3691

merged 1 commit into from
Nov 6, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 2, 2023

What does this PR do?

#3567 partially changed the ubi version to ubi9 but there were some other changes required in the packaging itself and the base docker images.

Why is it important?

ubi9 is not available yet.

Test

It ran in the CI

image
$ docker pull docker.elastic.co/observability-ci/elastic-agent-ubi9:52773d50b4496e1e2d5ba82736c69aa7862161e8
$ docker inspect docker.elastic.co/observability-ci/elastic-agent-ubi9:52773d50b4496e1e2d5ba82736c69aa7862161e8 | jq -r '.[0].Config.Labels' | grep ubi
  "com.redhat.component": "ubi9-minimal-container",

In addition

$ wget https://storage.googleapis.com/fleet-ci-artifacts/elastic-agent/commits/52773d50b4496e1e2d5ba82736c69aa7862161e8/elastic-agent-ironbank-8.12.0-SNAPSHOT-docker-build-context.tar.gz
$ tar xvzf elastic-agent-ironbank-8.12.0-SNAPSHOT-docker-build-context.tar.gz
x ./
x Dockerfile
x LICENSE
x README.md
x config
x config/docker-entrypoint
x hardening_manifest.yaml
$ grep -R ubi
./Dockerfile:ARG BASE_IMAGE=redhat/ubi/ubi9
./hardening_manifest.yaml:  BASE_IMAGE: "redhat/ubi/ubi9"

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v
Copy link
Member Author

v1v commented Nov 2, 2023

/package

@v1v v1v added ci:package Enable the package in the CI backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Nov 2, 2023
@mergify mergify bot assigned v1v Nov 2, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-03T10:45:16.471+0000

  • Duration: 82 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 4941
Skipped 57
Total 4998

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 2, 2023
@v1v v1v marked this pull request as ready for review November 3, 2023 08:37
@v1v v1v requested a review from a team as a code owner November 3, 2023 08:37
@v1v v1v requested review from blakerouse and pchila November 3, 2023 08:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@v1v
Copy link
Member Author

v1v commented Nov 3, 2023

/package

@v1v
Copy link
Member Author

v1v commented Nov 3, 2023

/test

@v1v
Copy link
Member Author

v1v commented Nov 3, 2023

@elastic/ingest-eng-prod , do you happen to know what's the reason for those errors in Buildkite? It seems they are also failing in the main branch but I'm afraid I cannot find what's the reason for those errors

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pierrehilbert
Copy link
Contributor

It's green now ;-)

Copy link
Contributor

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@jlind23 jlind23 merged commit a956f64 into elastic:main Nov 6, 2023
26 of 29 checks passed
mergify bot pushed a commit that referenced this pull request Nov 6, 2023
(cherry picked from commit a956f64)

# Conflicts:
#	dev-tools/packaging/templates/ironbank/Dockerfile.tmpl
#	dev-tools/packaging/templates/ironbank/hardening_manifest.yaml.tmpl
mergify bot pushed a commit that referenced this pull request Nov 6, 2023
(cherry picked from commit a956f64)
jlind23 added a commit that referenced this pull request Nov 6, 2023
cmacknz pushed a commit that referenced this pull request Nov 7, 2023
(cherry picked from commit a956f64)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify ci:package Enable the package in the CI skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants