Skip to content

docs: fix link to APM Overview #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

bmorelli25
Copy link
Member

In 7.16, the APM integration became generally available 🎉. As a part of this change, the APM Server Reference and APM Overview were deprecated and replaced with a new APM Guide. This PR updates a link in the ECS documentation to point to the new APM guide.

Unfortunately, when 7.17 is released, the old link will fail. To fix this, we need to backport this PR all the way to 1.3 😬 (which I'm happy to do). The broken links can be seen in elastic/docs#2333, but I've also included a summary below.

4:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.10/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.11/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.12/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.3/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.4/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.5/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.6/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.7/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.8/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/1.9/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/8.0/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/8.1/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/current/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html
14:17:47 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/ecs/master/ecs-products-solutions.html contains broken links to:
14:17:47 INFO:build_docs:   - en/apm/get-started/7.17/overview.html

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I don't mind handling the backports; hopefully, the backport tool should simplify the process. 😃

@bmorelli25
Copy link
Member Author

Thanks, Eric! I'll let you take care of it then 😄

@bmorelli25 bmorelli25 merged commit 8aea8e3 into elastic:main Jan 5, 2022
@bmorelli25 bmorelli25 deleted the fix-apm-links branch January 5, 2022 18:02
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jan 5, 2022
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
ebeahan added a commit that referenced this pull request Jan 5, 2022
Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants