Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move host metric fields RFC to finished #1316

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Move host metric fields RFC to finished #1316

merged 2 commits into from
Mar 25, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to move adding host metric fields RFC from candidate to finished.

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 25, 2021
@kaiyan-sheng kaiyan-sheng requested review from exekias and ebeahan March 25, 2021 15:49
ebeahan
ebeahan previously approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks!

@ebeahan ebeahan added the RFC label Mar 25, 2021
@ebeahan ebeahan merged commit 07ecb93 into elastic:master Mar 25, 2021
@ebeahan ebeahan mentioned this pull request Mar 25, 2021
Merged
@kaiyan-sheng kaiyan-sheng deleted the host_fields_stage3 branch March 26, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan left review comments

@exekias exekias Awaiting requested review from exekias

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiyan-sheng @ebeahan