-
Notifications
You must be signed in to change notification settings - Fork 28
ci: add release workflow #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@xrmx If I understand correctly, the Unless I'm missing something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
An enhancement we could add in a follow-up is moving the packages job into a reusable workflow and then we can run it both here in the release and in another workflow with a pull_request or push to main trigger to verify it's working before the release.
The elastic-apm-team account is listed as mantainer for this package |
Sorry, I don't know what that means. I haven't worked with pypi yet. But I assume you must set up a trust relationship between the pypi package and this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'll double check this and document what I've done, so we don't forget it :) Steps
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to support test-pypi too? similarly done in https://github.com/elastic/apm-agent-python/blob/dea50dd92a2cef299cbff08e339b4459a72ad453/.github/workflows/release.yml#L53-L57
Nah, the CI here is much simpler :) |
@elastic/observablt-robots This needs settings some secrets right?