Skip to content

ci: add release workflow #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024
Merged

ci: add release workflow #120

merged 2 commits into from
Jun 27, 2024

Conversation

xrmx
Copy link
Member

@xrmx xrmx commented Jun 26, 2024

@elastic/observablt-robots This needs settings some secrets right?

@xrmx xrmx requested review from basepi and a team June 26, 2024 13:20
@reakaleek
Copy link
Member

This needs settings some secrets right?

@xrmx If I understand correctly, the pypa/gh-action-pypi-publish action uses OIDC to authenticate. Hence, if everything is set up correctly on the pypi side. I don't see a need for any secrets.

Unless I'm missing something?

reakaleek
reakaleek previously approved these changes Jun 26, 2024
Copy link
Member

@reakaleek reakaleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

An enhancement we could add in a follow-up is moving the packages job into a reusable workflow and then we can run it both here in the release and in another workflow with a pull_request or push to main trigger to verify it's working before the release.

@xrmx
Copy link
Member Author

xrmx commented Jun 26, 2024

This needs settings some secrets right?

@xrmx If I understand correctly, the pypa/gh-action-pypi-publish action uses OIDC to authenticate. Hence, if everything is set up correctly on the pypi side. I don't see a need for any secrets.

Unless I'm missing something?

The elastic-apm-team account is listed as mantainer for this package

@reakaleek
Copy link
Member

This needs settings some secrets right?

@xrmx If I understand correctly, the pypa/gh-action-pypi-publish action uses OIDC to authenticate. Hence, if everything is set up correctly on the pypi side. I don't see a need for any secrets.
Unless I'm missing something?

The elastic-apm-team account is listed as mantainer for this package

Sorry, I don't know what that means. I haven't worked with pypi yet. But I assume you must set up a trust relationship between the pypi package and this repository.

v1v
v1v previously approved these changes Jun 26, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@v1v
Copy link
Member

v1v commented Jun 26, 2024

Sorry, I don't know what that means. I haven't worked with pypi yet. But I assume you must set up a trust relationship between the pypi package and this repository.

I'll double check this and document what I've done, so we don't forget it :)


Steps

image

@xrmx xrmx dismissed stale reviews from v1v and reakaleek via d54b85b June 26, 2024 14:34
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xrmx
Copy link
Member Author

xrmx commented Jun 26, 2024

Do you want to support test-pypi too? similarly done in https://github.com/elastic/apm-agent-python/blob/dea50dd92a2cef299cbff08e339b4459a72ad453/.github/workflows/release.yml#L53-L57

Nah, the CI here is much simpler :)

@xrmx xrmx merged commit bc21052 into elastic:main Jun 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants