-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support field customization #179
base: main
Are you sure you want to change the base?
Conversation
Support customization of fields on a per-request basis
💚 CLA has been signed |
We've reportedly signed a contributor agreement; I'm not sure how to get it to be reflected here. |
Going to try closing and reopening |
cla/check |
@jpage-godaddy Regarding the CLA, my understanding is that you or someone at GoDaddy will need to send an email to cla-questions@elastic.co asking to add you to your corporate CLA. Per this on https://www.elastic.co/contributor-agreement
I don't know how to verify on my end whether GoDaddy has a corporate CLA. Let me know if you hit a wall here and I can start asking around. |
Running You'll have to avoid the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The https://github.com/elastic/ecs-logging-nodejs/blob/main/docs/morgan.asciidoc#reference docs file should get an update for this. I can help with that if you like -- no need for you to learn asciidoc just for this.
Another request/comment below.
- Add docs - Change signature of customization function - Change test to use old JavaScript syntax
@trentm thanks for the review. I've made some updates and am ready for another pass. |
Support customization of fields on a per-request basis