Skip to content

Fix build when pointed at a worktree #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2019
Merged

Fix build when pointed at a worktree #860

merged 2 commits into from
May 3, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented May 2, 2019

When you do build_docs --doc ../foo/index.asciidoc and foo is a git
worktree then we blew up. This prevents that.

Closes #833

@nik9000
Fix build when pointed at a worktree
2cc635f 
When you do `build_docs --doc ../foo/index.asciidoc` and `foo` is a git
worktree then we blew up. This prevents that.

Closes elastic#833
@nik9000 nik9000 requested review from olksdr and jdconrad May 2, 2019 17:40
jdconrad
jdconrad reviewed May 2, 2019
View reviewed changes
Copy link

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, Nik! This LGTM, but I wouldn't feel comfortable approving without someone that has a better knowledge of Perl reviewing first :)

olksdr
olksdr approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@nik9000 nik9000 merged commit 15297f7 into elastic:master May 3, 2019
@nik9000
Copy link
Member Author

nik9000 commented May 3, 2019

Thanks for looking @olksdr and @jdconrad !

@henningandersen henningandersen mentioned this pull request Jan 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdconrad jdconrad jdconrad left review comments

@olksdr olksdr olksdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--doc doesn't like worktrees
3 participants
@nik9000 @olksdr @jdconrad