-
Notifications
You must be signed in to change notification settings - Fork 341
Add Cloud Hosted Release Notes book #3202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
I'm not sure if this is on the cloud side or this side, but I think something is wrong here because we're getting all of the pages rendered on one big super-page, no sidebar, and links are not working e.g. https://docs_bk_3202.docs-preview.app.elstc.co/guide/en/cloud-hosted/current/index.html ![]() |
Ah, it worked locally so I think it's because I used the "single: 1" which makes sense in the TPEC case but not here. Fixed in e90d5a1 |
couple small things:
otherwise, the structure looks good to me. we do have a lot of duplicate headings in the sidebar, but those were present in the old system. I am a little concerned about the links though - are we cool to rely on redirects to get people to the right place? e.g.: |
I've got this working by adding references to the version and shared attribute files in https://github.com/elastic/cloud/pull/139928
I changed it to "Elastic Cloud Release Notes" in https://github.com/elastic/cloud/pull/139928 but if there's a better name that's fine by me.
I updated the
I think since these are old release notes it's okay to have them point to the old docs. They're now working (i.e. pointing to "current") in https://github.com/elastic/cloud/pull/139928 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as long as this looks right after https://github.com/elastic/cloud/pull/139928, that all works for me !
run docs-build |
This PR is intended as an alternative to #3201, which aims to continue publishing the old Cloud Hosted release notes in the old docs system.