-
Notifications
You must be signed in to change notification settings - Fork 345
APM: simulate bump to 7.16 #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh, yikes. There are 1204 broken links 😨. Click to expand broken links
I don't see any easy way to address these links prior to 7.16 releasing, so maybe it makes sense to implement a workaround. I could add an if eval to the attributes file that reroutes APM Server and APM Overview attributes to the new APM Guide. Then, once 7.16 releases, I can go in and manually update all of the links in the APM agent books to use the new APM Guide attribute, and then remove the if eval. This would look something like this:
I'm going to add that ⬆️ to this PR and see what happens. |
That worked perfectly. All that remains are broken Cloud links. I'd be curious to hear your thoughts on this approach, @gtback. Click to expand broken Cloud/ES links
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be curious to hear your thoughts on this approach, @gtback.
This seems fine to me. I'm wary of adding complexity (especially complexity that needs to be maintained over time), but since this is just replacing one workaround (for 7.x, which doesn't exist anymore) with another one (for 7.16, which won't need to be changed, even if we don't go back and fix the existing links), 👍🏻
cc: @elastic/es-docs who will be managing the 7.16 docs release. |
Replaced by #2299. |
This PR bumps current from
7.15
to7.16
. I fear this will lead to hundreds of broken APM agent links, so I'm trying to get ahead of them.