Skip to content

Build 7.x branch of APM Guide #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2021
Merged

Build 7.x branch of APM Guide #2250

merged 2 commits into from
Oct 19, 2021

Conversation

bmorelli25
Copy link
Member

Adds the 7.x branch of the APM Guide to the build. For elastic/observability-docs#1073.

@bmorelli25 bmorelli25 requested review from gtback and a team October 19, 2021 19:34
@bmorelli25 bmorelli25 self-assigned this Oct 19, 2021
@bmorelli25 bmorelli25 mentioned this pull request Oct 19, 2021
Closed
25 tasks
@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

dedemorton
dedemorton reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you keep master as current instead of changing it to 7.x. My thought is that when the 7.x branch gets renamed to 7.16, you'll have a version 7.16 book marked as current, which might cause folks to think that 7.16 has been released.

gtback
gtback reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also have to be careful depending on whether this or #2249 gets merged first.

@bmorelli25
Copy link
Member Author

which might cause folks to think that 7.16 has been released.

Good point. It really doesn't matter which one is marked as current right now, so I'll change it back to master to avoid any potential confusion.

bmorelli25
bmorelli25 commented Oct 19, 2021
View reviewed changes
gtback
gtback approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dedemorton
dedemorton approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks groovy

@bmorelli25
Copy link
Member Author

I have Lisa's PR checked out. I'm going to merge this and immediately fix any conflicts it introduces.

@bmorelli25 bmorelli25 merged commit cd484bf into master Oct 19, 2021
@bmorelli25 bmorelli25 deleted the bmorelli25-patch-1 branch October 19, 2021 22:16
@gtback
Copy link
Member

gtback commented Oct 25, 2021

@bmorelli25 I'm setting up redirects for all books from 7.x to 7.16. Do you think we need one for this book? It didn't live very long, but I'm thinking it won't hurt to add one anyway.

@bmorelli25
Copy link
Member Author

Honestly, whatever is easier for you. While I agree that it wouldn't hurt, I don't think it's necessary.

@gtback
Copy link
Member

gtback commented Oct 25, 2021

@bmorelli25 👍🏻
I had to add a few other books to the list of redirects to add, so I included the APM Guide as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtback gtback gtback approved these changes

@dedemorton dedemorton dedemorton approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmorelli25 @gtback @dedemorton