Skip to content

[DOCS] Adds chunking to Py, Rust, and eland client books #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

[DOCS] Adds chunking to Py, Rust, and eland client books #1973

merged 1 commit into from
Oct 7, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Oct 5, 2020 •
edited
Loading

Overview

This PR adds the chunk: 1 attribute to the attribute list of the Python, Rust, and eland client books in the conf.yml and adds --chunk 1 to the respective book aliases in doc_build_aliases.sh.

These changes are required because of upcoming structural changes in the above-mentioned client books. This PR covers the last bits of infrastructural changes required to the Clients docs restructuring.

Note

Merge only the following PRs are merged:

@szabosteve szabosteve requested a review from gtback October 5, 2020 13:27
@szabosteve szabosteve added the docs DO NOT USE for *contents* of our docs. Only use for documentation *about* this repo. label Oct 5, 2020
@szabosteve szabosteve mentioned this pull request Oct 5, 2020
Merged
gtback
gtback approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We realized in #1970 that the chunking level is used by all versions of a book. In this case it's OK, since most of the client books only build one version, but wanted to explicitly call that out in case it matters.

@szabosteve szabosteve mentioned this pull request Oct 6, 2020
Merged
@szabosteve szabosteve merged commit a849e11 into elastic:master Oct 7, 2020
@szabosteve szabosteve deleted the py.el.ru.chunk branch October 7, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtback gtback gtback approved these changes

Assignees
No one assigned
Labels
docs DO NOT USE for *contents* of our docs. Only use for documentation *about* this repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabosteve @gtback