Docs ci switch jk to bk (#2898)

* Update air-gapped registry path

* Switch to using master and drop the _bk_ prefix for Buildkite builds

* update GH action to drop Jenkins references

* Remove secrets fetching that are no longer needed since we're using PAT

* Maintain the _bk_ in the Buildkite PRs - this is less confusing

Author: nkammah

.buildkite/air_gapped_pipeline.yml

@@ -3,7 +3,7 @@ steps:
     label: ":white_check_mark: Build and publish air-gapped doc"
     command: ".buildkite/scripts/publish_air_gapped_docs.sh"
     env:
-      AIR_GAPPED: "docker.elastic.co/docs-private/bk_air_gapped:latest"
+      AIR_GAPPED: "docker.elastic.co/docs-private/air_gapped:latest"
     agents:
       provider: "gcp"
       image: family/docs-ubuntu-2204

.buildkite/build_pipeline.yml

@@ -34,14 +34,6 @@ steps:
       provider: "gcp"
       image: family/docs-ubuntu-2204
       machineType: ${BUILD_MACHINE_TYPE}
-  - wait
-  - key: "branch-comparison"
-    label: "Compare branches"
-    command: |
-      .buildkite/scripts/compare_bk_jenkins_branches.sh staging master
-    agents:
-      provider: "gcp"
-      image: family/docs-ubuntu-2204
 notify:
   - email: "docs-status@elastic.co"
     if: build.state == "failed"

.buildkite/build_pr_pipeline.yml

@@ -27,11 +27,3 @@ steps:
       fi
     depends_on:
       - step: "build-pr"
-  - wait
-  - key: "branch-comparison"
-    label: "Compare branches"
-    command: |
-      .buildkite/scripts/compare_bk_jenkins_branches.sh ${GITHUB_PR_BASE_REPO}_bk_${GITHUB_PR_NUMBER} ${GITHUB_PR_BASE_REPO}_${GITHUB_PR_NUMBER}
-    agents:
-      provider: "gcp"
-      image: family/docs-ubuntu-2204

.buildkite/hooks/pre-command

@@ -27,14 +27,11 @@ export BUILD_MACHINE_TYPE="n2-standard-4"
 # Secrets must be redacted
 # https://buildkite.com/docs/pipelines/managing-log-output#redacted-environment-variables
 if [[ "$BUILDKITE_PIPELINE_SLUG" == "docs-build-pr" ]];then
-    export GITHUB_TOKEN=$(retry 5 vault kv get -field=value secret/ci/elastic-docs/docs_preview_cleaner)
     export BUILDKITE_API_TOKEN=$(retry 5 vault kv get -field=value secret/ci/elastic-docs/buildkite_token)
     if [[ ${GITHUB_PR_BASE_REPO:="unset"} == "docs" ]]; then
         # Docs PR require a full rebuild - so let's boost the builds so they don't take 2 hours
         export BUILD_MACHINE_TYPE="n2-highcpu-32"
     fi
-elif [[ "$BUILDKITE_PIPELINE_SLUG" == "docs-preview-cleaner" ]];then
-    export GITHUB_TOKEN=$(retry 5 vault kv get -field=value secret/ci/elastic-docs/docs_preview_cleaner)
 elif [[ "$BUILDKITE_PIPELINE_SLUG" == "docs-build" ]];then
     export BUILD_MACHINE_TYPE="n2-highcpu-32"
 elif [[ "$BUILDKITE_PIPELINE_SLUG" == "docs-build-air-gapped" ]] && [[ "$BUILDKITE_STEP_KEY" == "publish-air-gapped-doc" ]]; then

.buildkite/scripts/build.sh

@@ -25,8 +25,7 @@ elif [[ "${BROKEN_LINKS}" == 'warnlinkcheck' ]]; then
 fi
 
 if [[ "${BUILDKITE_BRANCH}" == "master" ]]; then
-  # temporary pushing to staging instead of master until the migration is over
-  build_args+=" --target_branch staging --push"
+  build_args+=" --push"
 fi
 
 # The docs build can use the ssh agent's authentication socket

.buildkite/scripts/compare_bk_jenkins_branches.sh

@@ -28,14 +28,10 @@ runs:
           const { REPO, PR, PREVIEW_PATH } = process.env
 
           const comment = `A documentation preview will be available soon.<br>
-          Help us out by validating the Buildkite preview and reporting issues [here](https://github.com/elastic/docs/issues/new?labels=buildkite-migration,bug).
-          Please also be sure to **double check all images to ensure they are correct** in the preview.
 
           - 🔨 Buildkite [builds](https://buildkite.com/elastic/docs-build-pr/builds?meta_data[repo_pr]=${REPO}_${PR})
-          - 📚 HTML diff: [Buildkite](https://${REPO}_bk_${PR}.docs-preview.app.elstc.co/diff)  - [Jenkins](https://${REPO}_${PR}.docs-preview.app.elstc.co/diff)
-          - 📙 Preview: [Buildkite](https://${REPO}_bk_${PR}.docs-preview.app.elstc.co/${PREVIEW_PATH})  -  [Jenkins](https://${REPO}_${PR}.docs-preview.app.elstc.co/${PREVIEW_PATH})
-          - 🧪 [Buildkite vs Jenkins diff](https://github.com/elastic/built-docs/compare/${REPO}_bk_${PR}..${REPO}_${PR})
-
+          - 📚 HTML [diff](https://${REPO}_bk_${PR}.docs-preview.app.elstc.co/diff)
+          - 📙 Preview [page](https://${REPO}_bk_${PR}.docs-preview.app.elstc.co/${PREVIEW_PATH})
 
           <details>
           <summary>Request a new doc build by commenting</summary>

.github/actions/docs-preview/action.yml

@@ -4,7 +4,7 @@
 
 set -eo pipefail
 
-export AIR_GAPPED=docker.elastic.co/docs-private/air_gapped:latest
+export AIR_GAPPED=docker.elastic.co/docs-private/bk_air_gapped:latest
 
 cd $(git rev-parse --show-toplevel)