Skip to content

[Rule Tuning] Update Tags for Cloud Rules #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 3, 2020
Merged

[Rule Tuning] Update Tags for Cloud Rules #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f71a3d8
[Rule Tuning] Update Tags for Cloud Rules
Jul 28, 2020
26303bb
commenting out specifying alphabetical tag order in rule formatter
Jul 28, 2020
c43990f
Update rule_formatter.py
Jul 28, 2020
059b0ac
py lint
Jul 28, 2020
9c6d158
Lint fix comments
rw-access Jul 28, 2020
ea478b5
update modified dates
Jul 28, 2020
65ebbe0
Update credential_access_secretsmanager_getsecretvalue.toml
Jul 31, 2020
faf0f3c
adding Continuous Monitoring tag
Jul 31, 2020
5cb2e3a
update tags
Jul 31, 2020
1088adc
fixed and in tags
Aug 3, 2020
42b5ab1
Merge branch '7.9' into update-tags-in-cloud-rules
bm11100 Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions detection_rules/rule_formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,11 @@ def _do_write(_data, _contents):
# but will at least purge extraneous white space
query = contents['rule'].pop('query', '').strip()

tags = contents['rule'].get("tags", [])

if tags and isinstance(tags, list):
contents['rule']["tags"] = list(sorted(set(tags)))
# - As tags are expanding, we may want to reconsider the need to have them in alphabetical order
# tags = contents['rule'].get("tags", [])
#
# if tags and isinstance(tags, list):
# contents['rule']["tags"] = list(sorted(set(tags)))

top = OrderedDict()
bottom = OrderedDict()
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/collection_cloudtrail_logging_created.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/10"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -28,7 +28,7 @@ references = [
risk_score = 21
rule_id = "594e0cbf-86cc-45aa-9ff7-ff27db27d3ed"
severity = "low"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/credential_access_aws_iam_assume_role_brute_force.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/07/16"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/16"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -24,7 +24,7 @@ references = [
risk_score = 47
rule_id = "ea248a02-bc47-4043-8e94-2885b19b2636"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Identity and Access", "Continuous Monitoring"]
type = "threshold"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/credential_access_iam_user_addition_to_group.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/04"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -26,7 +26,7 @@ references = ["https://docs.aws.amazon.com/IAM/latest/APIReference/API_AddUserTo
risk_score = 21
rule_id = "333de828-8190-4cf5-8d7c-7575846f6fe0"
severity = "low"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Identity and Access", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
8 changes: 4 additions & 4 deletions rules/aws/credential_access_secretsmanager_getsecretvalue.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/07/06"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/06"
updated_date = "2020/07/28"

[rule]
author = ["Nick Jones", "Elastic"]
Expand All @@ -27,10 +27,10 @@ references = [
"https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_GetSecretValue.html",
"http://detectioninthe.cloud/credential_access/access_secret_in_secrets_manager/",
]
risk_score = 21
risk_score = 73
rule_id = "a00681e3-9ed6-447c-ab2c-be648821c622"
severity = "low"
tags = ["AWS", "Elastic"]
severity = "high"
tags = ["AWS", "Elastic", "SecOps", "Data Protection", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_cloudtrail_logging_deleted.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/05/26"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -28,7 +28,7 @@ references = [
risk_score = 47
rule_id = "7024e2a0-315d-4334-bb1a-441c593e16ab"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_cloudtrail_logging_suspended.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/10"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -32,7 +32,7 @@ references = [
risk_score = 47
rule_id = "1aa8fa52-44a7-4dae-b058-f3333b91c8d7"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_cloudwatch_alarm_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/15"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -28,7 +28,7 @@ references = [
risk_score = 47
rule_id = "f772ec8a-e182-483c-91d2-72058f76a44c"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Monitoring", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_config_service_rule_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/26"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -32,7 +32,7 @@ references = [
risk_score = 47
rule_id = "7024e2a0-315d-4334-bb1a-552d604f27bc"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Monitoring", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_configuration_recorder_stopped.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/16"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -28,7 +28,7 @@ references = [
risk_score = 73
rule_id = "fbd44836-0d69-4004-a0b4-03c20370c435"
severity = "high"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Monitoring", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_ec2_flow_log_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/15"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -31,7 +31,7 @@ references = [
risk_score = 73
rule_id = "9395fd2c-9947-4472-86ef-4aceb2f7e872"
severity = "high"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_ec2_network_acl_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/05/26"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -33,7 +33,7 @@ references = [
risk_score = 47
rule_id = "8623535c-1e17-44e1-aa97-7a0699c3037d"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Network", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_guardduty_detector_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/05/28"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -31,7 +31,7 @@ references = [
risk_score = 73
rule_id = "523116c0-d89d-4d7c-82c2-39e6845a78ef"
severity = "high"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Monitoring", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_s3_bucket_configuration_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/05/27"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -31,7 +31,7 @@ references = [
risk_score = 21
rule_id = "227dc608-e558-43d9-b521-150772250bae"
severity = "low"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Asset Visibility", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_waf_acl_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/05/21"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -28,7 +28,7 @@ references = [
risk_score = 47
rule_id = "91d04cd4-47a9-4334-ab14-084abe274d49"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Network", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/defense_evasion_waf_rule_or_rule_group_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/09"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -28,7 +28,7 @@ references = [
risk_score = 47
rule_id = "5beaebc1-cc13-4bfc-9949-776f9e0dc318"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Network", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/execution_via_system_manager.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/07/06"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/06"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -29,7 +29,7 @@ references = ["https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-
risk_score = 21
rule_id = "37b211e8-4e2f-440f-86d8-06cc8f158cfa"
severity = "low"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/exfiltration_ec2_snapshot_change_activity.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/24"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -31,7 +31,7 @@ references = [
risk_score = 47
rule_id = "98fd7407-0bd5-5817-cda0-3fcc33113a56"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Asset Visibility", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/impact_cloudtrail_logging_updated.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/10"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand All @@ -28,7 +28,7 @@ references = [
risk_score = 21
rule_id = "3e002465-876f-4f04-b016-84ef48ce7e5d"
severity = "low"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/impact_cloudwatch_log_group_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/05/18"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -31,7 +31,7 @@ references = [
risk_score = 47
rule_id = "68a7a5a5-a2fc-4a76-ba9f-26849de881b4"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/impact_cloudwatch_log_stream_deletion.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/05/20"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -31,7 +31,7 @@ references = [
risk_score = 47
rule_id = "d624f0ae-3dd1-4856-9aad-ccfe4d4bfa17"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Logging", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
4 changes: 2 additions & 2 deletions rules/aws/impact_ec2_disable_ebs_encryption.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
creation_date = "2020/06/05"
ecs_version = ["1.5.0"]
maturity = "production"
updated_date = "2020/07/07"
updated_date = "2020/07/28"

[rule]
author = ["Elastic"]
Expand Down Expand Up @@ -32,7 +32,7 @@ references = [
risk_score = 47
rule_id = "bb9b13b2-1700-48a8-a750-b43b0a72ab69"
severity = "medium"
tags = ["AWS", "Elastic"]
tags = ["AWS", "Elastic", "SecOps", "Data Protection", "Continuous Monitoring"]
type = "query"

query = '''
Expand Down
Loading