[Bug] Remove Leftover KQL Normalize Code from Unit Test #3594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrancedejesus
added
bug
terrancedejesus
requested review from
brokensound77,
Mikaayenson and
eric-forte-elastic
as code owners
Mikaayenson
requested changes
Apr 15, 2024
There was a problem hiding this comment.
This may be a bug on your end @terrancedejesus. Did you update the kql package?
|
May be the result of this #3597; it may need to merge first. |
eric-forte-elastic
requested changes
Apr 17, 2024
|
Closing per discussion with @Mikaayenson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems the following code may have unintentionally been left behind from this addition. As a result,
test_lintfails when running unit tests.The code was reverted in this PR, but not from
LintTests.test_upper_tokens.When running unit tests on a branch created from main, I receive the following error:
