Skip to content

[APM] Remove old get-started and server docs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Dec 21, 2021

elastic/docs#2309 incorrectly moved APM docs from elastic.co/guide/en/apm/* to elastic.co/guide/*. This was fixed in elastic/docs#2324. built-docs doesn't automatically pick up this change, so the files at elastic.co/guide need to be deleted manually. This PR deletes all files in html/server/* and html/get-started/*. These files correspond to the APM docs here and here.

@bmorelli25 bmorelli25 self-assigned this Dec 21, 2021
@dedemorton
Copy link
Contributor

Only one obstacle I can think of here: is it possible that there are links to the old path (from Kibana or other docs)? If so, when you remove these files, you'll break the doc build. That seems very unlikely, though, since the new path was removed fairly quickly and our shared attributes file takes care of paths. I'll approve and you can decide what to do. I think merge it and we can always revert then clean up links, in the unlikely event that they break.

@bmorelli25
Copy link
Member Author

That's a good point. I think we're safe, but I'll revert if something breaks. I'm optimistic we'll be OK since these files haven't existed for long.

@bmorelli25 bmorelli25 merged commit 9b2683b into elastic:master Dec 21, 2021
@bmorelli25 bmorelli25 deleted the remove-incorrect-apm-docs branch December 21, 2021 20:37
@bmorelli25 bmorelli25 restored the remove-incorrect-apm-docs branch December 21, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants