Cherry-pick to 6.x: Add DeDot in add_docker_metadata processor (#9505) #9602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add DeDot in add_docker_metadata processor * Add dedot into config and default to be false * Update changelog and documentation * Add documentation into processors-using.asciidoc * Run mage fmt update under x-pack filebeat * Run mage fmt update on x-pack metricbeat * Run update again * Run make update fmt from top level dir * Remove mistakes from rebase * Remove repeated doc (cherry picked from commit 58573a9)
|
Travis CI failure is caused by #9597 |
ruflin
reviewed
Dec 18, 2018
| @@ -97,6 +97,22 @@ endif::[] | |||
| [[docker]] | |||
| *docker:* | |||
|
|
|||
| ifeval::["{release-state}"=="unreleased"] | |||
There was a problem hiding this comment.
How is this related to this PR?
There was a problem hiding this comment.
It's make update generated this in the original PR. Sorry I should have waited for one last review from you and Jaime.
| } |
There was a problem hiding this comment.
Nit: This change probably happened because you opened this file manually but it does not belong into this PR.
There was a problem hiding this comment.
Yeah hmm and I thought it's just an extra line but after deleting the extra line, it still shows up different.
This was referenced Dec 20, 2018
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
…ic#9505) (elastic#9602) * Cherry-pick to 6.x: Add DeDot in add_docker_metadata processor (elastic#9505) * Add DeDot in add_docker_metadata processor * Add dedot into config and default to be false * Update changelog and documentation * Add documentation into processors-using.asciidoc * Run mage fmt update under x-pack filebeat * Run mage fmt update on x-pack metricbeat * Run update again * Run make update fmt from top level dir * Remove mistakes from rebase * Remove repeated doc (cherry picked from commit 58573a9) * remove extra line in data.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the original PR:
This pr is for issue: #9350
Currently metrics from docker container is after dedot, which look like this:
and metrics from postgresql is not dedotted, which look like:
This PR will add a config option in add_docker_metadata processor to enable/disable dedot.
(cherry picked from commit 58573a9)