Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that packages.yml use the same files definition #8836

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Make sure that packages.yml use the same files definition #8836

merged 1 commit into from
Oct 31, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Oct 30, 2018

This PR make sure the definition style used by the packages.yml and the custom
function packages.yml match.

@ph
YAML is not a strict schema and we do not enforce strict fields
80c837c 
This PR make sure the definition style used by the packages.yml and the custom
function packages.yml match.
@ph ph added :Packaging in progress Pull request is currently in progress. labels Oct 30, 2018
@ph ph changed the title YAML is not a strict schema and we do not enforce strict fields Make sure that packages.yml use the same files definition Oct 30, 2018
andrewkroh
andrewkroh approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ph ph added review needs_backport PR is waiting to be backported to other branches. and removed in progress Pull request is currently in progress. labels Oct 31, 2018
@ph ph merged commit 93cedb8 into elastic:master Oct 31, 2018
@ph ph deleted the fix/yaml-correctly-define-files branch October 31, 2018 12:04
@ph ph mentioned this pull request Nov 15, 2018
Merged
@ph ph added v6.5.1 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 15, 2018
@ph ph mentioned this pull request Nov 15, 2018
Merged
@ph ph added the v6.6.0 label Nov 15, 2018
@ph ph mentioned this pull request Nov 15, 2018
Closed
ph added a commit that referenced this pull request Nov 15, 2018
@ph
Cherry-pick #8836 to 6.5: Make sure that packages.yml use the same fi…
b1c6ac8 
…les definition (#9103)

Cherry-pick of PR #8836 to 6.5 branch. Original message: 

This PR make sure the definition style used by the packages.yml and the custom
function packages.yml match.
ph added a commit that referenced this pull request Nov 15, 2018
@ph
Cherry-pick #8836 to 6.x: Make sure that packages.yml use the same fi…
87c1d60 
…les definition (#9104)

Cherry-pick of PR #8836 to 6.x branch. Original message: 

This PR make sure the definition style used by the packages.yml and the custom
function packages.yml match.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ph
Cherry-pick elastic#8836 to 6.5: Make sure that packages.yml use the …
77eed60 
…same files definition (elastic#9103)

Cherry-pick of PR elastic#8836 to 6.5 branch. Original message: 

This PR make sure the definition style used by the packages.yml and the custom
function packages.yml match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
:Packaging review v6.5.1 v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ph @andrewkroh