Index pod IP too in ip_port kubernetes indexer
#5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 27, 2017
| @@ -0,0 +1,22 @@ | |||
| package add_kubernetes_metadata | |||
There was a problem hiding this comment.
don't use an underscore in package name
houndci-bot
reviewed
Nov 27, 2017
| @@ -0,0 +1,22 @@ | |||
| package add_kubernetes_metadata | |||
There was a problem hiding this comment.
don't use an underscore in package name
exekias
force-pushed
the
ipport-ip-only
branch
from
b7493a2 to
c248541
Compare
exekias
changed the title
ip_portip_port kubernetes indexer
|
@exekias Can you rebase this one? |
Before this change it only indexed ip:port combination, but in some cases we want to have ip only, as source port may not be exported
exekias
force-pushed
the
ipport-ip-only
branch
from
c248541 to
8993ebd
Compare
|
done! |
ruflin
reviewed
Nov 28, 2017
| Data: commonMeta, | ||
| }) | ||
|
|
||
| for i := 1; i < len(hostPorts); i++ { |
There was a problem hiding this comment.
Should this be i := 0? Or are you skipping the first one because it is the podIP? If yes, perhaps add a comment here otherwise I think it's likely to break if this gets refactored.
There was a problem hiding this comment.
no, as the first item in the list will be the ip, this filters it to range on ip:port pairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, it only indexed ip:port combination, but in some cases, we want to have IP only, as source port may not be exported