Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #42895) fix(tests): ensure TestFilebeatOTelE2E does not fail if timestamps are equal #42904

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 26, 2025

Proposed commit message

The TestFilebeatOTelE2E test sometimes fails in CI. This test is designed to ensure that a document ingested by Filebeat and fbreceiver does not have any meaningful differences. Some fields are expected to change, such as agent.id, log.file.path, and at timestamp.

The test explicitly fails if any of the ignored fields match in both documents, as it assumes these fields should not be ignored. In the case of at timestamp, depending on how fast indexing works, it may sometimes match and sometimes differ, introducing flakiness to the test.

This check seems to do more harm than good and I have already removed it from a similar Elastic Agent test in elastic/elastic-agent#6819.

Example of a build failure caused by this: https://buildkite.com/elastic/beats-xpack-filebeat/builds/11240#01953eac-0d88-4ab5-aa5a-a1dcc909ecd4/179-688.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@mergify mergify bot added the backport label Feb 26, 2025
@mergify mergify bot requested a review from a team as a code owner February 26, 2025 09:55
@mergify mergify bot requested review from mauri870 and khushijain21 and removed request for a team February 26, 2025 09:55
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 26, 2025
@github-actions github-actions bot added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Feb 26, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 26, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 removed the request for review from khushijain21 February 26, 2025 10:00
@mauri870 mauri870 enabled auto-merge (squash) February 26, 2025 10:00
@mauri870 mauri870 merged commit cbc1cca into 8.x Feb 26, 2025
23 checks passed
@mauri870 mauri870 deleted the mergify/bp/8.x/pr-42895 branch February 26, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants