Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): ensure TestFilebeatOTelE2E does not fail if timestamps are equal #42895

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

mauri870
Copy link
Member

Proposed commit message

The TestFilebeatOTelE2E test sometimes fails in CI. This test is designed to ensure that a document ingested by Filebeat and fbreceiver does not have any meaningful differences. Some fields are expected to change, such as agent.id, log.file.path, and at timestamp.

The test explicitly fails if any of the ignored fields match in both documents, as it assumes these fields should not be ignored. In the case of at timestamp, depending on how fast indexing works, it may sometimes match and sometimes differ, introducing flakiness to the test.

This check seems to do more harm than good and I have already removed it from a similar Elastic Agent test in elastic/elastic-agent#6819.

Example of a build failure caused by this: https://buildkite.com/elastic/beats-xpack-filebeat/builds/11240#01953eac-0d88-4ab5-aa5a-a1dcc909ecd4/179-688.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@mauri870 mauri870 added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Feb 25, 2025
@mauri870 mauri870 self-assigned this Feb 25, 2025
@mauri870 mauri870 requested a review from a team as a code owner February 25, 2025 20:42
@mauri870 mauri870 requested review from faec and leehinman February 25, 2025 20:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 25, 2025
@mauri870
Copy link
Member Author

cc @khushijain21

@mauri870 mauri870 merged commit b14b1e0 into elastic:main Feb 26, 2025
23 checks passed
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
mauri870 added a commit that referenced this pull request Feb 26, 2025
…e equal (#42895) (#42904)

(cherry picked from commit b14b1e0)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Feb 26, 2025
…e equal (#42895) (#42905)

(cherry picked from commit b14b1e0)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants