Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore docker.network.in.* and docker.network.out.* fields in docker module #40968

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MichaelKatsoulis
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis commented Sep 24, 2024

Proposed commit message

  • WHAT: Restore docker.network.in.* and docker.network.out.* fields in docker module
  • WHY: These fields contain network incoming and outgoing stats per seconds and should not have been deprecated
    in favour of docker.network.inbound and docker.network.outbound which contain network stats since the container started.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

  1. Package metricbeat for docker PLATFORMS=linux/arm64 PACKAGES=docker mage package
  2. Bring up elastic-stack elastic-package stack up -d -v --version 9.0.0-SNAPSHOT
  3. In a machine (VM or local) with docker installed run Metricbeat by:
docker run -d \                                                                             
  --name=metricbeat \ 
  --user=root \
  --volume="$(pwd)/metricbeat.docker.yml:/usr/share/metricbeat/metricbeat.yml:ro" \
  --volume="/var/run/docker.sock:/var/run/docker.sock:ro" \
  --volume="/sys/fs/cgroup:/hostfs/sys/fs/cgroup:ro" \
  --volume="/proc:/hostfs/proc:ro" \
  --volume="/:/hostfs:ro" \
  docker.elastic.co/beats/metricbeat-oss:9.0.0 metricbeat -e \
  -E output.elasticsearch.hosts=["https://elasticsearch:9200"] -E output.elasticsearch.ssl.verification_mode=none -E  output.elasticsearch.username=elastic -E output.elasticsearch.password=changeme
  1. Explore the docker.network.in.* and docker.network.out.* in Kibana discover

Related issues

Screenshots

docker network

@MichaelKatsoulis MichaelKatsoulis requested a review from a team as a code owner September 24, 2024 13:02
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 24, 2024
Copy link

cla-checker-service bot commented Sep 24, 2024

💚 CLA has been signed

Copy link
Contributor

mergify bot commented Sep 24, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @MichaelKatsoulis? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 24, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 24, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 24, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 24, 2024
@MichaelKatsoulis MichaelKatsoulis added 8.16-candidate backport-8.15 Automated backport to the 8.15 branch with mergify labels Sep 24, 2024
@pierrehilbert
Copy link
Collaborator

@MichaelKatsoulis it seems strange to me to see the CLA being unhappy with your contribution.

@gizas
Copy link
Contributor

gizas commented Sep 24, 2024

@MichaelKatsoulis we will need an integration upgrade right? As I dont see the fields there

@MichaelKatsoulis
Copy link
Contributor Author

@MichaelKatsoulis it seems strange to me to see the CLA being unhappy with your contribution.

Maybe it is because I just got new laptop and I wrongly configured the email for git

@MichaelKatsoulis
Copy link
Contributor Author

@MichaelKatsoulis we will need an integration upgrade right? As I dont see the fields there

Yes the package will be updated accordingly whet it is time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.16-candidate backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants