-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tests that were muted during migration #40387
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
/test |
8c96eb7
to
c59595b
Compare
/test |
9c6bcdc
to
fc69628
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
@@ -7,7 +7,7 @@ set -euo pipefail | |||
PRIVATE_CI_GCS_CREDENTIALS_PATH="kv/ci-shared/platform-ingest/gcp-platform-ingest-ci-service-account" | |||
|
|||
if [[ "$BUILDKITE_PIPELINE_SLUG" == "beats-xpack-packetbeat" && "$BUILDKITE_STEP_KEY" == *"system-tests"* ]]; then | |||
PRIVATE_CI_GCS_CREDENTIALS_SECRET=$(retry -t 5 -- vault kv get -field plaintext -format=json ${PRIVATE_CI_GCS_CREDENTIALS_PATH}) | |||
PRIVATE_CI_GCS_CREDENTIALS_SECRET=$(vault kv get -field plaintext -format=json ${PRIVATE_CI_GCS_CREDENTIALS_PATH}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oakrizan Is this related to the test enablement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since win doesn't have minfrin/retry
x-pack/packetbeat/magefile.go
Outdated
mg.SerialDeps(getNpcapInstaller, devtools.BuildSystemTestBinary) | ||
// Buildkite (CI) images have preinstalled npcap | ||
if os.Getenv("CI") == "true" { | ||
mg.SerialDeps(devtools.BuildSystemTestBinary) | ||
} else { | ||
mg.SerialDeps(getNpcapInstaller, devtools.BuildSystemTestBinary) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oakrizan Is this related to the test enablement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've merged it in a separate MR. Will be removed after rebase
fc69628
to
2dc6a69
Compare
Higher level question... is this PR still needed? I think you used this to test whether the muted tests were still issues, and then opened individual tickets for the tests that still have problems. So would this PR stay open until all of those tickets are resolved (could be a while), or would those tests be re-enabled by a series of individual PRs? Or am I misinterpreting this, and those failing tests are still muted, but this PR is enabling all of the ones that are passing now? |
I'd assume it is, it's used as reference (code changes, build results) in issues that were created or moved to beats. |
2dc6a69
to
7ba2c7e
Compare
Proposed commit message
Enabled muted && skipped tests
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Logs