Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests that were muted during migration #40387

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Jul 30, 2024

Proposed commit message

Enabled muted && skipped tests

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2024
@oakrizan oakrizan added :Windows ci macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing Team:Ingest-EngProd labels Jul 30, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 30, 2024
Copy link
Contributor

mergify bot commented Jul 30, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @oakrizan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@oakrizan
Copy link
Contributor Author

/test

@oakrizan oakrizan force-pushed the postmigration-enable-tests branch 3 times, most recently from 8c96eb7 to c59595b Compare August 12, 2024 09:30
@oakrizan oakrizan changed the title Enable back tests that were disabled during migration Enable tests that were muted during migration Aug 13, 2024
@oakrizan
Copy link
Contributor Author

/test

Copy link
Contributor

mergify bot commented Aug 13, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b postmigration-enable-tests upstream/postmigration-enable-tests
git merge upstream/main
git push upstream postmigration-enable-tests

@@ -7,7 +7,7 @@ set -euo pipefail
PRIVATE_CI_GCS_CREDENTIALS_PATH="kv/ci-shared/platform-ingest/gcp-platform-ingest-ci-service-account"

if [[ "$BUILDKITE_PIPELINE_SLUG" == "beats-xpack-packetbeat" && "$BUILDKITE_STEP_KEY" == *"system-tests"* ]]; then
PRIVATE_CI_GCS_CREDENTIALS_SECRET=$(retry -t 5 -- vault kv get -field plaintext -format=json ${PRIVATE_CI_GCS_CREDENTIALS_PATH})
PRIVATE_CI_GCS_CREDENTIALS_SECRET=$(vault kv get -field plaintext -format=json ${PRIVATE_CI_GCS_CREDENTIALS_PATH})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oakrizan Is this related to the test enablement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since win doesn't have minfrin/retry

Comment on lines 168 to 173
mg.SerialDeps(getNpcapInstaller, devtools.BuildSystemTestBinary)
// Buildkite (CI) images have preinstalled npcap
if os.Getenv("CI") == "true" {
mg.SerialDeps(devtools.BuildSystemTestBinary)
} else {
mg.SerialDeps(getNpcapInstaller, devtools.BuildSystemTestBinary)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oakrizan Is this related to the test enablement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've merged it in a separate MR. Will be removed after rebase

@rowlandgeoff
Copy link
Contributor

Higher level question... is this PR still needed? I think you used this to test whether the muted tests were still issues, and then opened individual tickets for the tests that still have problems. So would this PR stay open until all of those tickets are resolved (could be a while), or would those tests be re-enabled by a series of individual PRs? Or am I misinterpreting this, and those failing tests are still muted, but this PR is enabling all of the ones that are passing now?

@oakrizan
Copy link
Contributor Author

Higher level question... is this PR still needed? I think you used this to test whether the muted tests were still issues, and then opened individual tickets for the tests that still have problems. So would this PR stay open until all of those tickets are resolved (could be a while), or would those tests be re-enabled by a series of individual PRs? Or am I misinterpreting this, and those failing tests are still muted, but this PR is enabling all of the ones that are passing now?

I'd assume it is, it's used as reference (code changes, build results) in issues that were created or moved to beats.
I think it might be helpful to see which PR labels and which code changes are required to make those tests run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Enable builds in the CI for ARM testing ci macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants