-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config check to replace processor #40047
Add config check to replace processor #40047
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
I think this may be overly strict. The implementation here prevents the use of the replace processor for removing a pattern; it is not possible to express |
…placement validation (#40801) * libbeat/processors/replace: fix zero string replacement validation (#40751) The change in #40047 breaks the use of the replace processor to do s/<pattern>// replacement. So make the validation on absence, not zero state. (cherry picked from commit a45a3ac) * add missing pr number --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
…eplacement validation (#40917) * libbeat/processors/replace: fix zero string replacement validation (#40751) The change in #40047 breaks the use of the replace processor to do s/<pattern>// replacement. So make the validation on absence, not zero state. (cherry picked from commit a45a3ac) * add missing pr number --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Proposed commit message
fixes #38747
This adds a validation method to the config for the
replace
processor, so we don't get a null pointer deref and explosion in cases where a user hasn't configured a regex pattern.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.