-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for kubernetes version 1.30.0 #39210
Add support for kubernetes version 1.30.0 #39210
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Note: Jenkins tests fail because it cannot create a kubernetes cluster with 1.30.0 version, as there is not such an image yet for kind in https://hub.docker.com/r/kindest/node/tags. |
/test |
The PR is now ready for review! |
deploy/kubernetes/Jenkinsfile.yml
Outdated
@@ -18,5 +18,5 @@ stages: | |||
make check-no-changes; | |||
stage: checks | |||
k8sTest: | |||
k8sTest: "v1.29.0,v1.28.0,v1.27.3,v1.26.6" | |||
k8sTest: "v1.30.0,v1.29.0,v1.28.0,v1.27.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the list based on the https://kubernetes.io/releases/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As kind is used to spin up the kubernetes clusters, we can only use the available kindest/node as found in https://hub.docker.com/r/kindest/node/tags?page=&page_size=&ordering=&name=.
The latest for 1.27 available is v1.27.13
For 1.28 the latest available is v1.28.9
For 1.29 the latest available is v1.29.4.
Do you suggest to use those or keep the ones we already have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter the better then. So I would say to update them
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in those files is defined K8S_VERSION
:
https://github.com/elastic/beats/blob/main/.buildkite/deploy/kubernetes/deploy-k8s-pipeline.yml
https://github.com/elastic/beats/blob/main/.buildkite/metricbeat/pipeline.yml
https://github.com/elastic/beats/blob/main/.buildkite/filebeat/filebeat-pipeline.yml
https://github.com/elastic/beats/blob/main/Jenkinsfile
should it be also updated?
Please update documentation https://github.com/elastic/beats/blob/main/metricbeat/module/kubernetes/_meta/docs.asciidoc#compatibility |
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
These tests are new. @oakrizan should we update those files, testing with the new kubernetes version as part of this PR ? |
This PR scope is to update and test the support of kubernetes version 1.30.0 for kubernetes metricbeat module . The tests and files of #39210 (review) are not maintained by elastic/obs-ds-hosted-services team. So I will leave them out of this PR. |
Proposed commit message
Add support to 1.30 Kubernetes version:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues