Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kubernetes version 1.30.0 #39210

Conversation

MichaelKatsoulis
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis commented Apr 25, 2024

Proposed commit message

Add support to 1.30 Kubernetes version:

  • Update documentation
  • Change K8s cluster version to 1.30
  • Update controller manager, scheduler and proxy metrics files.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@MichaelKatsoulis MichaelKatsoulis requested review from a team as code owners April 25, 2024 12:05
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 25, 2024
Copy link
Contributor

mergify bot commented Apr 25, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @MichaelKatsoulis? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 25, 2024

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-25T13:57:30.775+0000

  • Duration: 40 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 4583
Skipped 904
Total 5487

Steps errors 3

Expand to view the steps failures

Setup kind
  • Took 0 min 13 sec . View more details here
  • Description: .ci/scripts/kind-setup.sh
Integration tests
  • Took 1 min 27 sec . View more details here
  • Description: MODULE=kubernetes make -C metricbeat integration-tests
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@MichaelKatsoulis
Copy link
Contributor Author

MichaelKatsoulis commented Apr 29, 2024

Note:

Jenkins tests fail because it cannot create a kubernetes cluster with 1.30.0 version, as there is not such an image yet for kind in https://hub.docker.com/r/kindest/node/tags.
We should wait until the image gets released.

@MichaelKatsoulis
Copy link
Contributor Author

/test

@MichaelKatsoulis
Copy link
Contributor Author

The PR is now ready for review!
@fearful-symmetry or @faec could you also review it as part of data plane team?

@@ -18,5 +18,5 @@ stages:
make check-no-changes;
stage: checks
k8sTest:
k8sTest: "v1.29.0,v1.28.0,v1.27.3,v1.26.6"
k8sTest: "v1.30.0,v1.29.0,v1.28.0,v1.27.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the list based on the https://kubernetes.io/releases/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As kind is used to spin up the kubernetes clusters, we can only use the available kindest/node as found in https://hub.docker.com/r/kindest/node/tags?page=&page_size=&ordering=&name=.

The latest for 1.27 available is v1.27.13
For 1.28 the latest available is v1.28.9
For 1.29 the latest available is v1.29.4.

Do you suggest to use those or keep the ones we already have?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter the better then. So I would say to update them

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 26, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2024
Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tetianakravchenko
Copy link
Contributor

@cmacknz cmacknz added Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jun 26, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@cmacknz cmacknz removed Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 26, 2024
@MichaelKatsoulis
Copy link
Contributor Author

@MichaelKatsoulis
Copy link
Contributor Author

This PR scope is to update and test the support of kubernetes version 1.30.0 for kubernetes metricbeat module . The tests and files of #39210 (review) are not maintained by elastic/obs-ds-hosted-services team. So I will leave them out of this PR.

@MichaelKatsoulis MichaelKatsoulis merged commit 73f94b3 into elastic:main Jul 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants