Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 32-bit architectures from build scripts and support code #35789

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

faec
Copy link
Contributor

@faec faec commented Jun 15, 2023

Some Beats cross-builds are failing because we're still unintentionally packaging 32-bit builds, which haven't been supported since 8.0. This removes all live mentions in the build scripts and code to linux/386, windows/386, and darwin/386 architectures.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added bug Team:Elastic-Agent Label for the Agent team backport-v8.8.0 Automated backport with mergify labels Jun 15, 2023
@faec faec self-assigned this Jun 15, 2023
@faec faec requested review from a team as code owners June 15, 2023 17:07
@faec faec requested review from ycombinator and rdner June 15, 2023 17:07
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 15, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-15T19:37:27.383+0000

  • Duration: 81 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 27358
Skipped 2013
Total 29371

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@faec faec enabled auto-merge (squash) June 15, 2023 19:39
@faec faec merged commit e0150c5 into elastic:main Jun 15, 2023
mergify bot pushed a commit that referenced this pull request Jun 15, 2023
* Remove 32-bit architectures from build scripts and support code

* fix linter errors

(cherry picked from commit e0150c5)
@faec faec deleted the architecture-fix branch June 15, 2023 22:20
faec added a commit that referenced this pull request Jun 20, 2023
…) (#35792)

* Remove 32-bit architectures from build scripts and support code

* fix linter errors

(cherry picked from commit e0150c5)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.8.0 Automated backport with mergify bug Team:Automation Label for the Observability productivity team Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants