Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] Update error message for regenerating files during build #22277

Merged
merged 3 commits into from
Nov 3, 2020
Merged

[libbeat] Update error message for regenerating files during build #22277

merged 3 commits into from
Nov 3, 2020

Conversation

faec
Copy link
Contributor

@faec faec commented Oct 29, 2020

When the CI notices that some files haven't been regenerated, it says to run mage fmt update which is no longer a valid command. This PR changes the error message to recommend make update, which is the current way to regenerate files.

@faec faec added docs libbeat Team:Integrations Label for the Integrations team build-system Issue or change affecting Mage, Make, or build scripts. labels Oct 29, 2020
@faec faec requested a review from jsoriano October 29, 2020 17:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 29, 2020
@faec faec added needs_backport PR is waiting to be backported to other branches. needs_team Indicates that the issue/PR needs a Team:* label labels Oct 29, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 29, 2020
@botelastic
Copy link

botelastic bot commented Oct 29, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16380
Skipped 1344
Total 17724

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22277 opened]

  • Start Time: 2020-10-29T17:14:59.784+0000

  • Duration: 83 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 16380
Skipped 1344
Total 17724

@faec faec requested review from andrewkroh and removed request for jsoriano October 29, 2020 19:13
@faec faec merged commit b5fb9bf into elastic:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees
No one assigned
Labels
build-system Issue or change affecting Mage, Make, or build scripts. docs libbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faec @elasticmachine @fearful-symmetry