-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host inventory metrics to azure compute_vm metricset #20641
Merged
kaiyan-sheng
merged 6 commits into
elastic:master
from
kaiyan-sheng:add_host_data_azure
Aug 20, 2020
Merged
Add host inventory metrics to azure compute_vm metricset #20641
kaiyan-sheng
merged 6 commits into
elastic:master
from
kaiyan-sheng:add_host_data_azure
Aug 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 17, 2020
kaiyan-sheng
added
in progress
Pull request is currently in progress.
needs_backport
PR is waiting to be backported to other branches.
review
Team:Platforms
Label for the Integrations - Platforms team
labels
Aug 17, 2020
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 17, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
Collaborator
narph
reviewed
Aug 18, 2020
x-pack/metricbeat/module/azure/compute_vm/compute_vm_integration_test.go
Outdated
Show resolved
Hide resolved
narph
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kaiyan-sheng
added
test-plan
Add this PR to be manual test plan
and removed
in progress
Pull request is currently in progress.
labels
Aug 19, 2020
6 tasks
kaiyan-sheng
added
v7.10.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Aug 20, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Add host inventory metrics to azure compute_vm metricset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review
Team:Platforms
Label for the Integrations - Platforms team
test-plan
Add this PR to be manual test plan
test-plan-added
This PR has been added to the test plan
v7.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to add proposed host common fields into
compute
metricset:Why is it important?
This PR is a part of the inventory schema work.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
azure
module:./metricbeat modules enable azure
modules.d/azure.yml
to only includecompute_vm
metricset:add_host_metadata
processor config in metricbeat.yml file:compute_vm
metricset and includes fields listed above.