Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] fix event.type have incorrect value in system/syslog #20390

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

leehinman
Copy link
Contributor

What does this PR do?

In Filebeat system/syslog fileset change event.type = event to
event.kind = event

Why is it important?

"event" is not an allowed value for event.type in ECS.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=system mage -v pythonIntegTest

Related issues

@leehinman leehinman added bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Jul 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 31, 2020
event.type was being set to event.  event is not one of the allowed
values for event.type in ECS.  Changing field to event.kind, where
event is an allowed value.

Closes elastic#20365
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20390 opened]

  • Start Time: 2020-07-31T19:37:33.696+0000

  • Duration: 51 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 5516
Skipped 840
Total 6356

@leehinman leehinman merged commit 6843c55 into elastic:master Aug 10, 2020
@leehinman leehinman added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 10, 2020
leehinman added a commit to leehinman/beats that referenced this pull request Aug 10, 2020
event.type was being set to event.  event is not one of the allowed
values for event.type in ECS.  Changing field to event.kind, where
event is an allowed value.

Closes elastic#20365

(cherry picked from commit 6843c55)
leehinman added a commit that referenced this pull request Aug 11, 2020
event.type was being set to event.  event is not one of the allowed
values for event.type in ECS.  Changing field to event.kind, where
event is an allowed value.

Closes #20365

(cherry picked from commit 6843c55)
@leehinman leehinman deleted the 20365_event.type_value branch October 5, 2020 19:13
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
event.type was being set to event.  event is not one of the allowed
values for event.type in ECS.  Changing field to event.kind, where
event is an allowed value.

Closes elastic#20365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] system/syslog fileset sets event.type to illegal value
3 participants