Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate tags.resource_type_filter config parameter and replace with resource_type #19688

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Deprecate tags.resource_type_filter config parameter and replace with resource_type #19688

merged 4 commits into from
Jul 8, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 6, 2020 •
edited
Loading

This PR is to replace tags.resource_type_filter with a shorter more clear name resource_type in cloudwatch metricset.

With deprecating tags in #16733, when running cloudwatch metricset we will always get a warning message in the log about tags is deprecated. With renaming tags.resource_type_filter to resource_type, the warning log will not show up.

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Ingest Management labels Jul 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 6, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team and removed Team:Ingest Management labels Jul 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 6, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19688 updated]

  • Start Time: 2020-07-08T17:58:18.039+0000

  • Duration: 73 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 3390
Skipped 793
Total 4183

exekias
exekias approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please add some more details on why this change is good in the PR description?

@kaiyan-sheng kaiyan-sheng merged commit 88ea437 into elastic:master Jul 8, 2020
@kaiyan-sheng kaiyan-sheng deleted the cloudwatch_tags branch July 8, 2020 20:13
@kaiyan-sheng kaiyan-sheng mentioned this pull request Jul 8, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 8, 2020
kaiyan-sheng added a commit that referenced this pull request Jul 9, 2020
@kaiyan-sheng
Deprecate tags.resource_type_filter config parameter and replace with…
099f318 
… resource_type (#19688) (#19762)

* Deprecate tags.resource_type_filter config parameter

(cherry picked from commit 88ea437)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kaiyan-sheng @melchiormoulin
Deprecate tags.resource_type_filter config parameter and replace with…
e2ececc 
… resource_type (elastic#19688)

* Deprecate tags.resource_type_filter config parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Platforms Label for the Integrations - Platforms team v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @exekias