Add additional time formats to decode_cef #19346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class. The `zzz` specifier covers a few additional formats than what are covered by `MST` in Go's time format. Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additional adds support for the ISO8601 `Z` time zone value (this does not strictly match the CEF guide's format). These are the Java SimpleDateFormats in the CEF guide: MMM dd HH:mm:ss.SSS zzz MMM dd HH:mm:sss.SSS MMM dd HH:mm:ss zzz MMM dd HH:mm:ss MMM dd yyyy HH:mm:ss.SSS zzz MMM dd yyyy HH:mm:ss.SSS MMM dd yyyy HH:mm:ss zzz MMM dd yyyy HH:mm:ss .
andrewkroh
force-pushed
the
feature/fb/add-cef-timezones
branch
from
c02be48
to
57a27ef
Compare
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
marc-gr
approved these changes
Jun 25, 2020
andrewkroh
added
the
needs_backport
6 tasks
andrewkroh
added
v7.9.0
and removed
needs_backport
6 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 25, 2020
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class. The `zzz` specifier covers a few additional formats than what are covered by `MST` in Go's time format. Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additional adds support for the ISO8601 `Z` time zone value (this does not strictly match the CEF guide's format). These are the Java SimpleDateFormats in the CEF guide: MMM dd HH:mm:ss.SSS zzz MMM dd HH:mm:sss.SSS MMM dd HH:mm:ss zzz MMM dd HH:mm:ss MMM dd yyyy HH:mm:ss.SSS zzz MMM dd yyyy HH:mm:ss.SSS MMM dd yyyy HH:mm:ss zzz MMM dd yyyy HH:mm:ss (cherry picked from commit b82829b)
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 25, 2020
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class. The `zzz` specifier covers a few additional formats than what are covered by `MST` in Go's time format. Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additional adds support for the ISO8601 `Z` time zone value (this does not strictly match the CEF guide's format). These are the Java SimpleDateFormats in the CEF guide: MMM dd HH:mm:ss.SSS zzz MMM dd HH:mm:sss.SSS MMM dd HH:mm:ss zzz MMM dd HH:mm:ss MMM dd yyyy HH:mm:ss.SSS zzz MMM dd yyyy HH:mm:ss.SSS MMM dd yyyy HH:mm:ss zzz MMM dd yyyy HH:mm:ss (cherry picked from commit b82829b)
andrewkroh
added a commit
that referenced
this pull request
Jun 26, 2020
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class. The `zzz` specifier covers a few additional formats than what are covered by `MST` in Go's time format. Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additional adds support for the ISO8601 `Z` time zone value (this does not strictly match the CEF guide's format). These are the Java SimpleDateFormats in the CEF guide: MMM dd HH:mm:ss.SSS zzz MMM dd HH:mm:sss.SSS MMM dd HH:mm:ss zzz MMM dd HH:mm:ss MMM dd yyyy HH:mm:ss.SSS zzz MMM dd yyyy HH:mm:ss.SSS MMM dd yyyy HH:mm:ss zzz MMM dd yyyy HH:mm:ss (cherry picked from commit b82829b)
andrewkroh
added a commit
that referenced
this pull request
Jun 26, 2020
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class. The `zzz` specifier covers a few additional formats than what are covered by `MST` in Go's time format. Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additional adds support for the ISO8601 `Z` time zone value (this does not strictly match the CEF guide's format). These are the Java SimpleDateFormats in the CEF guide: MMM dd HH:mm:ss.SSS zzz MMM dd HH:mm:sss.SSS MMM dd HH:mm:ss zzz MMM dd HH:mm:ss MMM dd yyyy HH:mm:ss.SSS zzz MMM dd yyyy HH:mm:ss.SSS MMM dd yyyy HH:mm:ss zzz MMM dd yyyy HH:mm:ss (cherry picked from commit b82829b)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class. The `zzz` specifier covers a few additional formats than what are covered by `MST` in Go's time format. Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additional adds support for the ISO8601 `Z` time zone value (this does not strictly match the CEF guide's format). These are the Java SimpleDateFormats in the CEF guide: MMM dd HH:mm:ss.SSS zzz MMM dd HH:mm:sss.SSS MMM dd HH:mm:ss zzz MMM dd HH:mm:ss MMM dd yyyy HH:mm:ss.SSS zzz MMM dd yyyy HH:mm:ss.SSS MMM dd yyyy HH:mm:ss zzz MMM dd yyyy HH:mm:ss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The date formats in the CEF guide describe the time formats in terms of Java's SimpleTimeFormat class.
The
zzzspecifier covers a few additional formats than what are covered byMSTin Go's time format.Namely on the Go side it was missing support for offsets (e.g. +04, +0400, +04:00). This change additionally
adds support for the ISO8601
Ztime zone value (this does not strictly match the CEF guide's format).For reference these are the Java SimpleDateFormats in the CEF guide:
MMM dd HH:mm:ss.SSS zzz
MMM dd HH:mm:sss.SSS
MMM dd HH:mm:ss zzz
MMM dd HH:mm:ss
MMM dd yyyy HH:mm:ss.SSS zzz
MMM dd yyyy HH:mm:ss.SSS
MMM dd yyyy HH:mm:ss zzz
MMM dd yyyy HH:mm:ss
Why is it important?
It makes the decode_cef parser more closely match the CEF guide specification.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.