-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Packetbeat] ECS 1.5 update #19167
[Packetbeat] ECS 1.5 update #19167
Conversation
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👍 . Another person should look it over too. It needs a changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left a couple of minor suggestions.
* Add packetbeat changes * Fix up tests * Add changelog entry * Add compile time upgrade guard as a reminder and add inline marshal tag for ecs * Fix early termination for marshaling code (cherry picked from commit 9e9aa88)
* Add packetbeat changes * Fix up tests * Add changelog entry * Add compile time upgrade guard as a reminder and add inline marshal tag for ecs * Fix early termination for marshaling code
- Remove tls.detailed.{client,server}_certificate. - Update dashboards to use tls.{client,server}.x509.* instead of tls.detailed.{client,server}_certificate.* - Remove mappings for 'province'. Those fields was renamed in Packetbeat 7.9 to state_or_province (per ECS) (elastic/beats#19167).
* Sort all ecs.yml by field name [git-generate] cd packages/network_traffic for ds in $(ls data_stream); do yq -i '. | sort_by(.name)' data_stream/$ds/fields/ecs.yml; done for ds in $(ls data_stream); do yq -i 'sort_keys(..)' data_stream/$ds/fields/ecs.yml; done elastic-package format * Add missing dns.answers.* fields Arrays fields are not validated by elastic-package so these were missed. * Add missing TLS field mappings Add another TLS test case to expose more TLS fields. Import ECS mappings for all of `tls.*`. Convert tls.*.x509.version_number to string Remove unused tls.*.x509.version mapping * Remove duplicated TLS fields from Packetbeat 7.17 - Remove tls.detailed.{client,server}_certificate. - Update dashboards to use tls.{client,server}.x509.* instead of tls.detailed.{client,server}_certificate.* - Remove mappings for 'province'. Those fields was renamed in Packetbeat 7.9 to state_or_province (per ECS) (elastic/beats#19167). * Add missing event.* field mappings * Update readme [git-generate] cd packages/network_traffic elastic-package build * Add changelog entry [git-generate] cd packages/network_traffic elastic-package-changelog add-next -d "Add missing field mappings to DNS and TLS data streams." --type=bug --pr 3078
What does this PR do?
Updates
packetbeat
to use ECS categorization andrelated.ip
fields. Also, readies the TLS protocol parser to use the newx509
fields coming in 1.6.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues