-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow host.* fields to be disabled in Zeek module #19113
Merged
andrewkroh
merged 2 commits into
elastic:master
from
andrewkroh:feature/fb/disable-host-zeek
Jun 12, 2020
Merged
Allow host.* fields to be disabled in Zeek module #19113
andrewkroh
merged 2 commits into
elastic:master
from
andrewkroh:feature/fb/disable-host-zeek
Jun 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 10, 2020
If `forwarded` as configured as a tag (e.g. `var.tags: [forwarded]`) for the Zeek module then Filebeat will not add `host` fields to events. This is for use cases where Zeek is analyzing forwarded data (like from a network tap or mirror port). Relates: elastic#13920
andrewkroh
force-pushed
the
feature/fb/disable-host-zeek
branch
from
June 10, 2020 15:32
1f26175
to
0a6df63
Compare
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 10, 2020
Pinging @elastic/siem (Team:SIEM) |
marc-gr
approved these changes
Jun 12, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 15, 2020
…ngs-archive * upstream/master: Fix minor spelling error in Jenkinsfile (elastic#19153) [CI] fail if not possible to install python3 (elastic#19164) [Elastic Agent] Improved mage demo experience (elastic#18445) [yum] Clear cached data and add retry loop (elastic#19182) fix lint job by updating NOTICE (elastic#19161) Fix tags for coredns/envoyproxy (elastic#19134) Disable host.* fields by default for CrowdStrike module (elastic#19132) Allow host.* fields to be disabled in Zeek module (elastic#19113) Rename to management.Manager, add UpdateStatus to Manager interface. (elastic#19114) Edit Elastic Agent docs (elastic#19146) [JJBB] create job definition for the golang-crossbuild project (elastic#19162) Fix incorrect usage of hints builder when exposed port is a substring of the hint (elastic#19052) Add basic cloudfoundry integration tests (elastic#19018)
andrewkroh
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Jun 18, 2020
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 18, 2020
If `forwarded` as configured as a tag (e.g. `var.tags: [forwarded]`) for the Zeek module then Filebeat will not add `host` fields to events. This is for use cases where Zeek is analyzing forwarded data (like from a network tap or mirror port). Relates: elastic#13920 (cherry picked from commit 018b17c)
5 tasks
andrewkroh
added
v7.9.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Jun 18, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
If `forwarded` as configured as a tag (e.g. `var.tags: [forwarded]`) for the Zeek module then Filebeat will not add `host` fields to events. This is for use cases where Zeek is analyzing forwarded data (like from a network tap or mirror port). Relates: elastic#13920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If
forwarded
as configured as a tag (e.g.var.tags: [forwarded]
) for the Zeek module then Filebeat will not addhost
fields to events. This is for use cases where Zeek is analyzing forwarded data (like from a network tap or mirror port).Why is it important?
We want Filebeat to follow Elastic Common Schema. And setting host with the correct value is part of that. By setting (or not setting host) we can better interpret events. Without this change the Filebeat host is being attributed as the source even if data was received over a network tap or mirror port.
Checklist
[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues