Add IP* fields to fields.yml generator script #18256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
enhancement
needs_backport
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
the
needs_team
kvch
added
:Generator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kvch
force-pushed
the
feature-fields-generator-more-types
branch
from
4b67a21
to
c4f31ac
Compare
jsoriano
approved these changes
May 7, 2020
kvch
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the following patterns to the fields.yml generator with the type
ip:IPIPV4IPV6Why is it important?
From now on
fields.ymlgenerator is able to guess the correct type for fields which match the patterns mentioned above.Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #17998