Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17275 to 7.x: Add documentation for deploying filebeat and metricbeat in Cloud Foundry. #17298

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Mar 27, 2020

Cherry-pick of PR #17275 to 7.x branch. Original message:

What does this PR do?

Adds documentation on running filebeat and metricbeat inside of Cloud Foundry.

Why is it important?

Because almost all operators of Cloud Foundry will want to deploy it inside of the foundation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Follow the instructions to ensure it results in a running filebeat and metricbeat inside of Cloud Foundry.

Related issues

@blakerouse blakerouse requested a review from a team March 27, 2020 17:58
@blakerouse blakerouse added the Team:Platforms Label for the Integrations - Platforms team label Mar 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

…dry. (elastic#17275)

* Add running-on-cloudfoundry for filebeat.

* Fix typo.

* Add running on cloudfoundry for metricbeat.

* Add changelog.

* Add missing newline at end of metricbeat manifest.

* Fix filebeat being referenced in metricbeat docs.

(cherry picked from commit 850d1fa)
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 Changelog entries?

@blakerouse
Copy link
Contributor Author

@sayden being that it added documentation for both metricbeat and filebeat I added 2, the original PR also had 2 (one for each)

Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Gotcha, I didn't realize. Thanks!

@blakerouse blakerouse merged commit 69e1102 into elastic:7.x Apr 3, 2020
@blakerouse blakerouse deleted the backport_17275_7.x branch April 3, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants