Use max in k8s apiserver dashboard aggregations #17018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
bug
enhancement
review
:Dashboards
needs_backport
exekias
approved these changes
Mar 23, 2020
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Mar 23, 2020
(cherry picked from commit d748008)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the following aggregations:
Why is it important?
Each of these visualization is taking a sum of
kubernetes.apiserver.request.countand then a derivative, howeverkubernetes.apiserver.request.countis a counter and hence we should be using max with the derivative.Related issues