Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change url.path to use NOTSPACE grok pattern instead #13225

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Change url.path to use NOTSPACE grok pattern instead #13225

merged 4 commits into from
Aug 23, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

This is a PR to change grok pattern from URIPATH to NOTSPACE so in url.path, special characters are enabled such as À¯ and Áœ. The log example used in this PR came from https://discuss.elastic.co/t/seeing-error-in-iis-module/187901.

closes #12710

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner August 12, 2019 20:47
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 12, 2019
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe NOTSPACE is too permisive, but ok.

Actually we could also consider NOTSPACE as an option to overcome this issue #8814, at least in some cases.

@nicpenning
Copy link
Contributor

Thank you for looking into this! I greatly appreciate it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in IIS module for filebeat.
4 participants