Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Remove unset auid and session fields #11815

Merged
merged 2 commits into from
Apr 18, 2019

Conversation

adriansr
Copy link
Contributor

The auditd module sets user.audit.id and auditd.session to unset when they are not present in the original event.

This changes this behavior and removes the fields from the event. The same logic is applied to any other *ID field that might be marked as unset.

Closes #11431

The auditd module sets `user.audit.id` and `auditd.session` to `unset`
when they are not present in the original event.

This changes this behavior and removes the fields from the event. The
same logic is applied to any other *ID field that might be marked as
unset.

Closes elastic#11431
@adriansr adriansr added enhancement discuss Issue needs further discussion. review Auditbeat labels Apr 15, 2019
@adriansr adriansr requested a review from a team as a code owner April 15, 2019 06:13
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please put a breaking change entry for Auditbeat into the changelog.

Copy link

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. Looked it over and it looks good to me.

@adriansr adriansr merged commit a3856b9 into elastic:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat discuss Issue needs further discussion. enhancement review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Auditbeat] Remove unset user.auid and auditd.session
3 participants