-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] allow ingest pipelines in YAML format #11209
Conversation
This updates the ingest pipeline loading to look at the pipeline definition file extension and use a JSON or YAML decoder depending on the type.
Didn't add a test, but #11171 includes a YAML pipeline that will be used during tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely improves readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great idea. Looking forward to our first .yml pipeline.
This could even be worth an entry in the dev changelog.
The Filebeat modules generator documentation also needs a follow-up. When generating a new Filebeat fileset, it would be nice to provide a YAML pipeline instead of a JSON. Or maybe making it configurable, if someone prefers JSON over YAML. |
I would keep the default as JSON as otherwise it might be confusing the users. My guess is that most users are not aware that ES API's support YAML. |
OK. Still the documentation needs to be updated. |
This updates the ingest pipeline loading to look at the pipeline definition file extension and use a JSON or YAML decoder depending on the type.
This improves readability a lot, as now it's possible to add comments and multiline strings.