Skip to content

Commit e982a79

Browse files
committed
simplify reading lines
1 parent 12e2a58 commit e982a79

File tree

7 files changed

+12
-21
lines changed

7 files changed

+12
-21
lines changed

auditbeat/include/fields.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

filebeat/include/fields.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

heartbeat/include/fields.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libbeat/generator/fields/fields.go

+6-15
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package fields
33
import (
44
"bufio"
55
"fmt"
6-
"io"
76
"io/ioutil"
87
"os"
98
"path"
@@ -55,25 +54,17 @@ func writeGeneratedFieldsYml(beatsPath string, fieldFiles []*YmlFile) error {
5554
return err
5655
}
5756

58-
fr := bufio.NewReader(ff)
59-
for {
60-
l, err := fr.ReadString('\n')
61-
if err != nil {
62-
if err == io.EOF {
63-
err = writeIndentedLine(fw, l+"\n", p.Indent)
64-
if err != nil {
65-
return err
66-
}
67-
break
68-
}
69-
return err
70-
}
71-
err = writeIndentedLine(fw, l, p.Indent)
57+
fs := bufio.NewScanner(ff)
58+
for fs.Scan() {
59+
err = writeIndentedLine(fw, fs.Text()+"\n", p.Indent)
7260
if err != nil {
7361
return err
7462
}
7563

7664
}
65+
if err := fs.Err(); err != nil {
66+
return err
67+
}
7768
}
7869
return nil
7970
}

metricbeat/include/fields.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)