Skip to content

Commit 8e55272

Browse files
authored
Fix various memory leaks under Windows (#12100) (#12122)
A function in go-sysinfo used under Windows to split a command-line into arguments was leaking memory. This code was used in various places: add_process_metadata processor. (enabled by default in all Beats) Packetbeat's process monitor. (disabled by default). Auditbeat's system/process metricset. This PR updates vendored go-sysinfo to the most recent version, which fixes the leak. (cherry picked from commit a5b3f0a)
1 parent c01de67 commit 8e55272

File tree

14 files changed

+232
-42
lines changed

14 files changed

+232
-42
lines changed

CHANGELOG.next.asciidoc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,12 @@ https://github.com/elastic/beats/compare/v6.7.2...6.8[Check the HEAD diff]
3333

3434
*Affecting all Beats*
3535

36+
- Fixed a memory leak when using the add_process_metadata processor under Windows. {pull}12100[12100]
37+
3638
*Auditbeat*
3739

3840
- Package dataset: Log error when Homebrew is not installed. {pull}11667[11667]
41+
- Process dataset: Fixed a memory leak under Windows. {pull}12100[12100]
3942

4043
*Filebeat*
4144

@@ -50,6 +53,8 @@ https://github.com/elastic/beats/compare/v6.7.2...6.8[Check the HEAD diff]
5053

5154
*Packetbeat*
5255

56+
- Fixed a memory leak when using process monitoring under Windows. {pull}12100[12100]
57+
5358
*Winlogbeat*
5459

5560
*Functionbeat*

NOTICE.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -541,15 +541,15 @@ Apache License 2.0
541541

542542
--------------------------------------------------------------------
543543
Dependency: github.com/elastic/go-sysinfo
544-
Revision: ab4f04edfc3d6b3864f5f06a068ddab9ad79774f
544+
Revision: 9a4be54a53be4c48b44d351d52fb425a5e274be5
545545
License type (autodetected): Apache-2.0
546546
./vendor/github.com/elastic/go-sysinfo/LICENSE.txt:
547547
--------------------------------------------------------------------
548548
Apache License 2.0
549549

550550
-------NOTICE.txt-----
551551
Elastic go-sysinfo
552-
Copyright 2017-2018 Elasticsearch B.V.
552+
Copyright 2017-2019 Elasticsearch B.V.
553553

554554
This product includes software developed at
555555
Elasticsearch, B.V. (https://www.elastic.co/).

vendor/github.com/elastic/go-sysinfo/CHANGELOG.md

Lines changed: 51 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/elastic/go-sysinfo/NOTICE.txt

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/elastic/go-sysinfo/README.md

Lines changed: 44 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/elastic/go-sysinfo/go.mod

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/elastic/go-sysinfo/go.sum

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/elastic/go-sysinfo/providers/darwin/process_darwin_amd64.go

Lines changed: 18 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/elastic/go-sysinfo/providers/linux/container.go

Lines changed: 5 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/elastic/go-sysinfo/providers/linux/host_linux.go

Lines changed: 18 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)