Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove context.db from S3 spans: S3 isn't a database #683

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Remove context.db from S3 spans: S3 isn't a database #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions specs/agents/tracing-instrumentation-db.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,6 @@ The following fields are relevant for database and datastore spans. Where possib
|`type`|`storage`|
|`subtype`|`s3`|
|`action`| e.g. `GetObject` | The operation name in PascalCase. |
| __**context.db._**__ |<hr/>|<hr/>|
|`_.instance`| e.g. `us-east-1` | The AWS region where the bucket is. |
|`_.statement`| :heavy_minus_sign: | |
|`_.type`|`s3`|
|`_.user`| :heavy_minus_sign: |
|`_.link`| :heavy_minus_sign: |
|`_.rows_affected`| :heavy_minus_sign: |
| __**context.destination._**__ |<hr/>|<hr/>|
|`_.address`|e.g. `s3.amazonaws.com`| Not available in some cases. Only set if the actual connection is available. |
|`_.port`|e.g. `443`| Not available in some cases. Only set if the actual connection is available. |
Expand Down Expand Up @@ -153,15 +146,15 @@ The Elasticsearch cluster name is not always available in ES clients, as a resul
#### `elasticsearch_capture_body_urls` configuration

The URL patterns for which the agent is capturing the request body for Elasticsearch clients.

Agents MAY offer this configuration option.
If they don't, they MUST use a hard-coded list of URLs that correspond with the default value of this option.

| | |
|----------------|------------|
| Type | `List<`[`WildcardMatcher`](../../tests/agents/json-specs/wildcard_matcher_tests.json)`>` |
| Default | `*/_search, */_search/template, */_msearch, */_msearch/template, */_async_search, */_count, */_sql, */_eql/search`|
| Central config | `false`
| Central config | `false`

### MongoDB

Expand Down