Enclose etag and IfNoneMatch header in double quotes. #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass except for the Integration Tests, where failure is unrelated. |
|
Jenkins, run the tests again please |
graphaelli
approved these changes
Jul 9, 2019
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 9, 2019
* Enclose etag and IfNoneMatch header in double quotes. fixes elastic#2404
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 9, 2019
* Enclose etag and IfNoneMatch header in double quotes. fixes elastic#2404
|
@elastic/apm-agent-devs please be aware of this change. |
|
Note for other agent devs who might be about to do the same as I was about to do: If you or your http framework doesn't strip the double quotes from |
watson
added a commit
to watson/apm-nodejs-http-client
that referenced
this pull request
Jul 9, 2019
simitt
added a commit
that referenced
this pull request
Jul 10, 2019
simitt
added a commit
that referenced
this pull request
Jul 10, 2019
7 tasks
Qard
pushed a commit
to watson/apm-nodejs-http-client
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2404
needs backport to
7.xand7.3.