Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against various Faraday exception response formats #1428

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

dalibor
Copy link
Contributor

@dalibor dalibor commented Dec 13, 2023

What does this pull request do?

  • Guard against other Faraday exception response formats
  • Fix randomly failing test by stubbing getconf shell out

Why is it important?

To prevent errors while fetching status in Faraday rescue client/server errors block.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

@dalibor dalibor changed the title Guard against other Faraday exception response formats Guard against various Faraday exception response formats Dec 13, 2023
@dalibor
Copy link
Contributor Author

dalibor commented Dec 20, 2023

@estolfo @picandocodigo Could someone from the team review this PR please?

Also, we'll need a new official version released since 4.7.0 is not compatible with Rails 7.1.

Thanks!

@picandocodigo
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@picandocodigo picandocodigo merged commit bd51c21 into elastic:main Jan 9, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants